fix(vllm): align vLLM-Omni pin with bundled vLLM 0.23.0 - #11374
Merged
dagil-nvidia merged 3 commits intoJul 8, 2026
Conversation
release/1.3.0 bundles vLLM 0.23.0 but pinned vllm_omni_ref to v0.21.0rc1. vLLM-Omni imports internal vLLM symbols that change across releases, so a major/minor skew crashes at import time with an opaque ImportError before the unified-omni worker can register (/v1/models stays empty). - Bump vllm_omni_ref v0.21.0rc1 -> v0.23.0rc1 to match the bundled vLLM. - Port the vllm-omni#4568 cherry-pick (OmniRequest *args ordering) needed by v0.23.0rc1 against vLLM 0.23's positional Request construction. - Refresh the stale version reference comment in protected_packages.txt. Signed-off-by: tanmayv25 <tanmayv@nvidia.com>
This comment has been minimized.
This comment has been minimized.
| exit 1 | ||
| fi | ||
|
|
||
| if patch -p1 -d "${omni_site}" --forward --dry-run < "${cherry_pick_patch}" >/dev/null 2>&1; then |
There was a problem hiding this comment.
The script now invokes patch, but the vLLM runtime image only installs jq before this step and does not guarantee the patch utility, so the image build can fail with command not found. Fix: install patch before running install_vllm_omni.sh.
🤖 AI Fix
Update container/templates/vllm_runtime.Dockerfile in the apt-get install RUN block immediately before the vLLM-Omni install to include patch in the apt-get install -y --no-install-recommends package list with jq.
The lychee job fails on docs/contribution-guide.md(.zh-CN) because https://github.com/ai-dynamo/dynamo/stargazers returns 404 to the unauthenticated GitHub runner (the page loads fine in a browser). Add it to .lycheeignore, matching the existing pi-dynamo-provider convention, so the check passes without altering the docs. Signed-off-by: tanmayv25 <tanmayv@nvidia.com>
This was referenced Jul 10, 2026
dagil-nvidia
pushed a commit
that referenced
this pull request
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
release/1.3.0bundles vLLM 0.23.0 (runtime_image_tag: v0.23.0-ubuntu2404/ cpuv0.23.0) butcontainer/context.yamlpinsvllm_omni_refto v0.21.0rc1. vLLM-Omni is built against a specific vLLM release line and imports internal vLLM symbols that are added/renamed/removed across releases. A major/minor skew therefore crashes at import time with an opaqueImportError, before the unified-omni worker can register — so the Frontend's/v1/modelsstays permanently empty and no image/video/audio request is ever served.This is the failure originally reported against
1.3.0-rc.2(omni 0.21.x vs vLLM 0.23.0). The same alignment fix landed onmain(#11345) for the 0.24 line; this backports it torelease/1.3.0for the 0.23 line.Fix
vllm_omni_refv0.21.0rc1→v0.23.0rc1(the vLLM-Omni build aligned with vLLM 0.23.0) incontainer/context.yaml.vllm-project/vllm-omni#4568cherry-pick intocontainer/deps/vllm/install_vllm_omni.sh. In the releasedv0.23.0rc1,OmniRequest.__init__declares*argsafter its named parameters; vLLM 0.23's positionalRequest(...)construction misbinds the arguments and EngineCore init fails for all vLLM workers (vLLM-Omni monkeypatchesRequestat import time). The commit moves*argsto the front and forwards cleanly.container/deps/vllm/protected_packages.txt.Test
vllm-runtimeimage is required for the pin change to take effect.main(omni/vLLM 0.24.0) was validated end-to-end: cleandynamo.vllm.unified_omniimport, omni worker registers,/v1/modelspopulated, andPOST /v1/videoscompletes with a valid MP4.