Skip to content

fix(vllm): align vLLM-Omni pin with bundled vLLM 0.23.0 - #11374

Merged
dagil-nvidia merged 3 commits into
release/1.3.0from
tanmayv/fix-omni-version-release-1.3.0
Jul 8, 2026
Merged

fix(vllm): align vLLM-Omni pin with bundled vLLM 0.23.0#11374
dagil-nvidia merged 3 commits into
release/1.3.0from
tanmayv/fix-omni-version-release-1.3.0

Conversation

@tanmayv25

Copy link
Copy Markdown
Contributor

Overview

release/1.3.0 bundles vLLM 0.23.0 (runtime_image_tag: v0.23.0-ubuntu2404 / cpu v0.23.0) but container/context.yaml pins vllm_omni_ref to v0.21.0rc1. vLLM-Omni is built against a specific vLLM release line and imports internal vLLM symbols that are added/renamed/removed across releases. A major/minor skew therefore crashes at import time with an opaque ImportError, before the unified-omni worker can register — so the Frontend's /v1/models stays permanently empty and no image/video/audio request is ever served.

This is the failure originally reported against 1.3.0-rc.2 (omni 0.21.x vs vLLM 0.23.0). The same alignment fix landed on main (#11345) for the 0.24 line; this backports it to release/1.3.0 for the 0.23 line.

Fix

  • Bump vllm_omni_ref v0.21.0rc1v0.23.0rc1 (the vLLM-Omni build aligned with vLLM 0.23.0) in container/context.yaml.
  • Port the vllm-project/vllm-omni#4568 cherry-pick into container/deps/vllm/install_vllm_omni.sh. In the released v0.23.0rc1, OmniRequest.__init__ declares *args after its named parameters; vLLM 0.23's positional Request(...) construction misbinds the arguments and EngineCore init fails for all vLLM workers (vLLM-Omni monkeypatches Request at import time). The commit moves *args to the front and forwards cleanly.
  • Refresh the stale version reference comment in container/deps/vllm/protected_packages.txt.

Test

  • A rebuild of the vllm-runtime image is required for the pin change to take effect.
  • The equivalent alignment on main (omni/vLLM 0.24.0) was validated end-to-end: clean dynamo.vllm.unified_omni import, omni worker registers, /v1/models populated, and POST /v1/videos completes with a valid MP4.

release/1.3.0 bundles vLLM 0.23.0 but pinned vllm_omni_ref to v0.21.0rc1.
vLLM-Omni imports internal vLLM symbols that change across releases, so a
major/minor skew crashes at import time with an opaque ImportError before
the unified-omni worker can register (/v1/models stays empty).

- Bump vllm_omni_ref v0.21.0rc1 -> v0.23.0rc1 to match the bundled vLLM.
- Port the vllm-omni#4568 cherry-pick (OmniRequest *args ordering) needed
  by v0.23.0rc1 against vLLM 0.23's positional Request construction.
- Refresh the stale version reference comment in protected_packages.txt.

Signed-off-by: tanmayv25 <tanmayv@nvidia.com>
@tanmayv25
tanmayv25 requested a review from a team as a code owner July 7, 2026 23:00
@tanmayv25
tanmayv25 requested a review from a team July 7, 2026 23:00
@tanmayv25
tanmayv25 requested review from a team as code owners July 7, 2026 23:00
@copy-pr-bot

copy-pr-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added fix backend::vllm Relates to the vllm backend container labels Jul 7, 2026
@datadog-official

This comment has been minimized.

exit 1
fi

if patch -p1 -d "${omni_site}" --forward --dry-run < "${cherry_pick_patch}" >/dev/null 2>&1; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script now invokes patch, but the vLLM runtime image only installs jq before this step and does not guarantee the patch utility, so the image build can fail with command not found. Fix: install patch before running install_vllm_omni.sh.

🤖 AI Fix

Update container/templates/vllm_runtime.Dockerfile in the apt-get install RUN block immediately before the vLLM-Omni install to include patch in the apt-get install -y --no-install-recommends package list with jq.

tanmayv25 and others added 2 commits July 8, 2026 14:33
The lychee job fails on docs/contribution-guide.md(.zh-CN) because
https://github.com/ai-dynamo/dynamo/stargazers returns 404 to the
unauthenticated GitHub runner (the page loads fine in a browser). Add it
to .lycheeignore, matching the existing pi-dynamo-provider convention, so
the check passes without altering the docs.

Signed-off-by: tanmayv25 <tanmayv@nvidia.com>
@dagil-nvidia
dagil-nvidia merged commit e5b5e7c into release/1.3.0 Jul 8, 2026
18 of 19 checks passed
@dagil-nvidia
dagil-nvidia deleted the tanmayv/fix-omni-version-release-1.3.0 branch July 8, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants