fix(vllm): align vLLM-Omni pin with bundled vLLM 0.24.0

[tanmayv25]

Overview

The vllm-runtime image bundles vLLM 0.24.0 but container/context.yaml pinned vllm_omni_ref to v0.23.0rc1. vLLM-Omni is built against a specific vLLM release line and imports internal vLLM symbols (e.g. split_routed_experts) that are added/renamed/removed across releases. A major/minor skew therefore crashes at import time with an opaque ImportError, before the unified-omni worker can register — so the Frontend's /v1/models stays permanently empty and no image/video/audio request is ever served.

This is the same class of failure originally reported against 1.3.0-rc.2 (omni 0.21.x vs vLLM 0.23.0); on main it re-appeared as omni 0.23.x vs vLLM 0.24.0.

Fix

• Bump vllm_omni_ref to v0.24.0 (the vLLM-Omni build aligned with upstream vLLM 0.24.0) in container/context.yaml.
• Refresh the stale version reference comment in container/deps/vllm/protected_packages.txt.

Note: vLLM-Omni releases can lag vLLM, so the refs are aligned manually per release rather than enforced in lockstep.

Test

Rebuilt the vllm-runtime image (x86_64) with the aligned pin and ran the aggregated omni worker:

• from dynamo.vllm.unified_omni import VllmOmniEngine imports cleanly (previously crashed on split_routed_experts).
• The omni worker starts and registers; the Frontend's /v1/models is populated.
• End-to-end POST /v1/videos with Wan-AI/Wan2.1-T2V-1.3B-Diffusers returns status: "completed" and writes a valid H.264 MP4.

A rebuild of the vllm-runtime image is required for the pin change to take effect.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

Walkthrough

Adds a version_check.py module implementing a fail-fast compatibility check between installed vllm and vllm-omni package versions, wires it into module import in omni/__init__.py, adds corresponding unit tests, and bumps the bundled vllm-omni reference version in container configuration files.

Changes

Version compatibility guard

Layer / File(s)	Summary
Compatibility check implementation components/src/dynamo/vllm/omni/version_check.py	Adds OmniVersionMismatchError and check_vllm_omni_compatibility(), which parses installed vllm/vllm-omni versions via importlib.metadata, skips on unparseable/missing metadata, and raises on major/minor mismatch.
Wire check into package import components/src/dynamo/vllm/omni/__init__.py	Calls the compatibility check at import time before importing handler classes, with # noqa: E402 comments to allow the reordered imports.
Compatibility check tests components/src/dynamo/vllm/tests/omni/test_omni_version_check.py	New pytest module testing version parsing edge cases, mismatch error raising with version details in the message, aligned-version success, and behavior when package metadata lookup fails.
Bundled vllm-omni version update container/context.yaml, container/deps/vllm/protected_packages.txt	Bumps vllm_omni_ref from v0.23.0rc1 to v0.24.0 with added version-matching comments, and updates the safetensors requirement comment to reference v0.24.0.

Estimated code review effort: 2 (Simple) | ~12 minutes

Suggested labels: vllm, tests, container

Suggested reviewers: dynamo vLLM maintainers

🐰 A version check hops in with care,
Comparing vLLM pairs to spare,
If numbers clash, it won't proceed,
It logs, it guards, then plants the seed,
Of v0.24.0 everywhere!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the overview, fix, and test, but it omits the required Details, reviewer start point, and Related Issues sections.	Add the missing template sections: Details, Where should reviewer start?, and Related Issues with either a linked issue or the no-issue confirmation.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise and accurately summarizes the main change: aligning the vLLM-Omni pin with bundled vLLM 0.24.0.

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

components/src/dynamo/vllm/tests/omni/test_omni_version_check.py (1)

66-72: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Simulate the real exception type for the missing-metadata case.

This test raises a generic Exception to simulate missing metadata, but importlib.metadata.version() actually raises importlib.metadata.PackageNotFoundError for a missing package. If the broad except Exception in version_check.py is narrowed to catch PackageNotFoundError (recommended in that file's review), this test would start failing with an unhandled exception instead of exercising the skip path.

🔧 Proposed fix

 def test_missing_metadata_is_skipped():
     def _raise(name):
-        raise Exception("no metadata")
+        raise importlib.metadata.PackageNotFoundError(name)
 
     with patch("importlib.metadata.version", _raise):
         # Should not raise; downstream import handles the missing package.
         check_vllm_omni_compatibility()

(requires import importlib.metadata at the top of this test module)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@components/src/dynamo/vllm/tests/omni/test_omni_version_check.py` around
lines 66 - 72, The missing-metadata test is using a generic Exception, which
won’t match the real failure mode from importlib.metadata.version. Update
test_missing_metadata_is_skipped to patch importlib.metadata.version so it
raises importlib.metadata.PackageNotFoundError instead, and add the needed
importlib.metadata import at the top of the test module. This keeps
check_vllm_omni_compatibility exercised through the intended skip path and
aligns the test with version_check.py behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@components/src/dynamo/vllm/omni/version_check.py`:
- Around line 33-41: Move the importlib.metadata dependency in version_check.py
to module scope and access it via importlib.metadata.version inside the version
check logic, rather than importing version inside the function. Narrow the
exception handling in the version check helper to only catch
importlib.metadata.PackageNotFoundError instead of a bare Exception, keeping the
existing debug log and early return for missing packages. Preserve test
patchability by continuing to resolve version through the module attribute
rather than binding a local imported function.

In `@components/src/dynamo/vllm/tests/omni/test_omni_version_check.py`:
- Around line 16-23: The spacing before the top-level helper `_fake_version` is
incorrect for `black`; add one more blank line after the `pytestmark` list so
there are two blank lines before the function definition, matching the
formatting expected by `black`.

---

Nitpick comments:
In `@components/src/dynamo/vllm/tests/omni/test_omni_version_check.py`:
- Around line 66-72: The missing-metadata test is using a generic Exception,
which won’t match the real failure mode from importlib.metadata.version. Update
test_missing_metadata_is_skipped to patch importlib.metadata.version so it
raises importlib.metadata.PackageNotFoundError instead, and add the needed
importlib.metadata import at the top of the test module. This keeps
check_vllm_omni_compatibility exercised through the intended skip path and
aligns the test with version_check.py behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 12f873f1-125d-42b2-b89c-d3ccb0bdce07

📥 Commits

Reviewing files that changed from the base of the PR and between b650c53 and 501e23b.

📒 Files selected for processing (5)

• components/src/dynamo/vllm/omni/__init__.py
• components/src/dynamo/vllm/omni/version_check.py
• components/src/dynamo/vllm/tests/omni/test_omni_version_check.py
• container/context.yaml
• container/deps/vllm/protected_packages.txt

[alec-flowers]

I wouldn't force bumping in cadence. vllm comes out ahead of vllm-omni so we can't gate on it.

[tanmayv25]

Duplicate: #11248

[tthakkal]

Duplicate: #11248

@tanmayv25 you can keep one and close other, your PR missing other required changes.
Removal of workaround logic in install_vllm_omni.sh and changes needed to fix failure tests.