Repository navigation
Conversation
Lift the one-aggregated-worker/1P1D limit on AgentX G2 in both the Python sweeper gate and the native JSON entrypoint. Each worker publishes its G2 residency as native HostPinned KV events, so a KV-aware placement policy (such as Dynamo's Router) follows a G2-resident prefix to its owner, and snapshot/profile plays keep play-local token identities so hits never cross a recycled play. vLLM, attention DP1 on every role, static pools, and no speculation or G3 remain required; zero or non-integer worker counts are still rejected. Tests cover multi-replica aggregated and P/D runs through the public API and native JSON payloads. Docs and CLI help describe the new boundary. Signed-off-by: Harry Lee <harrli@nvidia.com>
…[AISIM-1894] Document ownership, discovery, play-scoped identity, contention, stale-entry fallback, membership, and disable semantics of a cluster-shared G2 pool under AgentX. A public-API test runs 2P2D on one shared pool (capacity counted once) and checks that switching to dp_rank_local reproduces the private-G2 report exactly, even with shared-only fields left set. Signed-off-by: Harry Lee <harrli@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
 |
Harrilee
force-pushed
the
harrli/aisim-1893-agentx-multi-replica-g2
branch
from
November 3, 2026 01:43
51b7802 to
1fae23b
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves AISIM-1894 (AISimulate side). Stacked on #688 (AISIM-1893). Retarget to
mainafter that merges.This PR documents the
cluster_sharedG2 contract under AgentX indocs/replay/engine/kv-cache.md:HostPinnedto every subscribed rank when its D2H completes, and pool-wide LRU removals are published the same way.dp_rank_localreproduces private G2.New public-API test: 2P2D on one shared pool reports a single 8-block domain. Switching the scope to
dp_rank_localreproduces the private-G2 report exactly, even when shared-only bandwidth fields are left set.The deterministic replica-level assertions (play-scoped sharing, recycled-play isolation, concurrent-consumer accounting, stale fallback) run through the Dynamo Router in ai-dynamo/dynamo#17879.
Validation
tests/test_agentx_g2.py: 38 passed. Ruff check/format clean.