Repository navigation
fix: accept native dense KV skip evidence in FPM collection - #529
simone-chen wants to merge 5 commits into
Conversation
Signed-off-by: Simone Chen <simonec@nvidia.com>
|
/ok to test 8d62746 |
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
jasonqinzhou
left a comment
There was a problem hiding this comment.
Automated approval from the AISimulate PR Review Monitor, enabled by Jason.
Reviewed commit: 8d6274611c10af602db70fdcab46a00a400b6e8b
9.3/10 · high confidence
Accept Dynamo's explicit per-point dense KV skip marker during formal FPM aggregation, alongside the historical fallback stamp. The PR retains the existing eligibility checks and documents and tests both producer formats.
9.3/10, APPROVE. The change consumes the validated per-point regime through the existing dense full-attention, runtime, and topology gate. No actionable defect was found, and exact-head hosted Fast CI and Full CI passed. Local native-extension limitations are documented in the verification and residual risks.
* ci: switch workflows to renamed AISim runner pools Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> * ci: recognize AISim runner labels in actionlint Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> * ci: use the ARC job-pod workspace for HOME Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> * ci: add containerized canaries for the runner cutover Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> * ci: activate controlled canaries after runner registration Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> * ci: respect the shared runner execution contract Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> --------- Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> (cherry picked from commit 976d75a) Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@nvidia.com>
Signed-off-by: Jason Zhou <jasonzho@nvidia.com>
Why and what changed
skip:dense_model_content_insensitive, without the olderkvwarm_fake_fallbackstamp. AISimulate main currently converts these otherwise qualified measurements tofake_fallback, leaving dense decode unusable.Review map
collector/fpm_forward/database.py::aggregate_cellandtests/unit/collector/test_fpm_dense_synthetic_kv.pyunderpython/aisimulate/.Evidence
test_fpm_dense_synthetic_kv.py,test_fpm_worker_probe_artifact.py,test_fpm_forward.pyandtest_fpm_measurement_evidence.py, usingpython -m pytest -c python/aisimulate/pytest.ini -p no:timeoutwith this worktree's Python source onPYTHONPATH.git diff --checkpassed.Modeling or data provenance
Tracking