Skip to content

Grants Program review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agryaznov merged 4 commits into from
Nov 25, 2021
Merged

Grants Program review #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53eb8eb
Swap local dep for a remote crate
mmagician Nov 22, 2021
205e777
Typos & whitespace fixes
mmagician Nov 22, 2021
1c5dc27
Add TODOs
mmagician Nov 22, 2021
529859a
typos fixes accepted, TODO addressed as N\A, formatting spaces reverted
agryaznov Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ default-features = false
scale = { package = "parity-scale-codec", version = "2.1", default-features = false, features = ["derive"] }
scale-info = { version = "1.0", default-features = false, features = ["derive"], optional = true }

ink_prelude = { version = "3.0.0-rc6", path = "../ink/crates/prelude", default-features = false }
ink_prelude = { version = "3.0.0-rc6", default-features = false }


[lib]
Expand Down
6 changes: 3 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ mod candle_auction {
#[cfg_attr(feature = "std", derive(scale_info::TypeInfo))]
/// Error types
pub enum Error {
/// Returned if bidding whilr auction isn't in active status
/// Returned if bidding while auction isn't in active status
AuctionNotActive,
/// Placed bid_new isn't outbidding current winning nid_quo
/// (bid_new, bid_quo) returned for info
Expand Down Expand Up @@ -254,7 +254,7 @@ mod candle_auction {
}
}

// pay the looser his bidded amount back
// pay the loser his bid amount back
let bal = self.balances.take(&to).unwrap();
// zero-balance check: bid 0 is possible, but nothing to pay back
if bal > 0 {
Expand Down Expand Up @@ -310,7 +310,7 @@ mod candle_auction {
///
/// DESIGN DECISION: we call ERC721 set_approval_for_all() instead of approve() for
/// 1. the sake of simplicity, no need to specify TokenID
/// as we need to send this token to the contract anyway, _ater_ instantiation
/// as we need to send this token to the contract anyway, _after_ instantiation
/// but still _before_ auctions starts
/// 2. this allows to set auction for collection of tokens instead of just for one thing
///
Expand Down