Grants Program review#1
Merged
Merged
Conversation
agryaznov
reviewed
Nov 22, 2021
|
|
||
| // pay the looser his bidded amount back | ||
| // pay the loser his bid amount back | ||
| // TODO: shouldn't we handle multiple accounts here? I guess the |
Owner
There was a problem hiding this comment.
Please see line 415: the payout is invoked by each participant by himself. Which is considered fair enough as winner payout presumably takes more gas fees to execute, hence everyone pays his own fees only
agryaznov
reviewed
Nov 22, 2021
5 tasks
Owner
|
@mmagician thanks! this PR is partially accepted, providing comments explaining why proposed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I made some small fixes: