Skip to content

Read the signing identity and team from repository variables #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agoodkind merged 1 commit into from
Aug 10, 2026
Merged

Read the signing identity and team from repository variables #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,13 @@ jobs:
# because fastlane provisions instead. SWIFT_MK_VERIFY_SIGNING_ROOTS verifies each
# runnable product is signed with the team and is not ad-hoc.
import-signing-cert: true
signing-identity-name: "Apple Distribution: Alex Goodkind (H3BMXM4W7H)"
apple-team-id: H3BMXM4W7H
# The identity and team come from repository variables, so rotating a
# certificate or moving teams is one settings edit rather than a commit in
# every repository. The two certificates keep separate variables: this job
# signs Apple Distribution, the release signs Developer ID, and one shared
# slot for both was a defect once already.
signing-identity-name: ${{ vars.APPLE_DISTRIBUTION_IDENTITY }}
apple-team-id: ${{ vars.APPLE_TEAM_ID }}
setup-target: ci-provision
make-args: TUIST_DEVELOPER_ID_SIGNING=1
secrets: inherit
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ jobs:
# publishes something a person can download, marked as not the recommended build,
# and a run that proves itself is promoted to stable deliberately.
release-on-merge: prerelease
signing-identity-name: "Developer ID Application: Alex Goodkind (H3BMXM4W7H)"
apple-team-id: H3BMXM4W7H
# Developer ID here, Apple Distribution in CI. Both come from repository
# variables, and each keeps its own so the two are never confused.
signing-identity-name: ${{ vars.APPLE_DEVELOPER_ID_IDENTITY }}
apple-team-id: ${{ vars.APPLE_TEAM_ID }}
notarize-pattern: "*.zip"
candidate-asset-pattern: "*.zip"
sbom-subject-path: "Products/Release/CellTunnelAgent.app"
Expand Down
Loading