Skip to content

Read the signing identity and team from repository variables - #112

Merged
agoodkind merged 1 commit into
mainfrom
signing-identity-to-ci-vars
Aug 10, 2026
Merged

agoodkind merged 1 commit into
mainfrom
signing-identity-to-ci-vars

Conversation

@agoodkind

Copy link
Copy Markdown
Owner

Co-authored-by: Claude noreply@anthropic.com

Co-authored-by: Claude <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 9, 2026 20:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: c3d9cc19-f3dc-4484-a70f-95479a75b3f6

📥 Commits

Reviewing files that changed from the base of the PR and between 8848277 and c7193d2.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The CI and release workflows now source Apple signing identities and the Apple team ID from repository variables. The release workflow also documents the distinction between Developer ID and Apple Distribution identities.

Changes

Apple signing configuration

Layer / File(s) Summary
Workflow signing variables
.github/workflows/ci.yml, .github/workflows/release.yml
The workflows use repository variables for Apple signing identities and the Apple team ID. Release comments distinguish Developer ID from Apple Distribution identities.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only provides a co-authorship attribution and does not describe the workflow changes. Add a brief summary that the CI and release workflows now read the signing identity and Apple team ID from repository variables.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the signing identity and team are now read from repository variables.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch signing-identity-to-ci-vars

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@agoodkind
agoodkind merged commit 5aa3fd5 into main Aug 10, 2026
18 of 26 checks passed
@agoodkind
agoodkind deleted the signing-identity-to-ci-vars branch August 10, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants