IPv6 support#761
Merged
imobachgs merged 17 commits intoagama-project:masterfrom Sep 25, 2023
imobachgs:ipv6-support
Merged
Conversation
* It implies parsing the addresses in the CLI.
teclator
reviewed
Sep 25, 2023
rust/agama-dbus-server/src/network/dbus/interfaces/ip_config.rs
Outdated
Show resolved
Hide resolved
teclator
reviewed
Sep 25, 2023
rust/agama-dbus-server/src/network/dbus/interfaces/ip_config.rs
Outdated
Show resolved
Hide resolved
teclator
reviewed
Sep 25, 2023
rust/agama-dbus-server/src/network/dbus/interfaces/ip_config.rs
Outdated
Show resolved
Hide resolved
teclator
approved these changes
Sep 25, 2023
Contributor
teclator
left a comment
There was a problem hiding this comment.
LGTM, just added some suggestions but np ones.
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Support for IPv6 is missing.
Solution
Initially, this PR implemented an additional
IPv6interface to support IPv6 settings. However, after some discussion, we decided to simplify the D-Bus interface and the schema as much as possible, keeping all IP configuration under a singleorg.opensuse.Agama1.Network.IPinterface.An example
Notes
This is an alternative to #758.
Testing
To do