Skip to content

IPv6 support#761

Merged
imobachgs merged 17 commits intoagama-project:masterfrom
imobachgs:ipv6-support
Sep 25, 2023
Merged

IPv6 support#761
imobachgs merged 17 commits intoagama-project:masterfrom
imobachgs:ipv6-support

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Sep 20, 2023

Problem

Support for IPv6 is missing.

Solution

Initially, this PR implemented an additional IPv6 interface to support IPv6 settings. However, after some discussion, we decided to simplify the D-Bus interface and the schema as much as possible, keeping all IP configuration under a single org.opensuse.Agama1.Network.IP interface.

An example

  "network": {
    "connections": [
      {
        "id": "Ethernet network device 1",
        "method4": "manual",
        "method6": "manual",
        "interface": "eth0",
        "addresses": [
          "192.168.122.100/24",
          "::ffff:c0a8:7ac7/64"
        ],
        "gateway4": "192.168.122.1",
        "gateway6": "::ffff:c0a8:7a01",
        "nameservers": [
          "192.168.122.1",
          "2001:4860:4860::8888"
        ]
      }
    ]

Notes

This is an alternative to #758.

Testing

  • Added a new unit test
  • Tested manually

To do

  • Add support for IPv6
  • Unify IPv4 and IPv6 interfaces
  • Adapt the schema
  • Adapt the examples
  • Fix the documentation
  • Add more tests

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 25, 2023

Coverage Status

coverage: 72.381% (+0.1%) from 72.255% when pulling aac2a36 on imobachgs:ipv6-support into 4005226 on openSUSE:master.

@imobachgs imobachgs marked this pull request as ready for review September 25, 2023 10:55
Copy link
Copy Markdown
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added some suggestions but np ones.

Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>
@imobachgs imobachgs merged commit a3fe255 into agama-project:master Sep 25, 2023
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
@imobachgs imobachgs deleted the ipv6-support branch September 27, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants