WIP: Add Ipv6 support to BaseConnection#758
Closed
jcronenberg wants to merge 2 commits intoagama-project:masterfrom
Closed
WIP: Add Ipv6 support to BaseConnection#758jcronenberg wants to merge 2 commits intoagama-project:masterfrom
jcronenberg wants to merge 2 commits intoagama-project:masterfrom
Conversation
Contributor
Author
|
I think the approach of #761 is better. So let's continue with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ipv6 is missing from Agama BaseConnection
Solution
This PR aims to implement what is already there for ipv4 in BaseConnection also for ipv6.
Testing
Notes
To not duplicate all the code I used the duplicate crate which makes the process of creating macros easier. The macros could also of course be written into the code directly but like I said this makes it more convenient and also has a cleaner syntax IMO. However it of course introduces a new dependency, let me know if this is a problem.
I also tried my hand at using generics to solve the code duplication problem but ran into some issues where honestly my rust knowledge wasn't enough, so if this path is desired I would need some help.
Let me know what you think 🙂