Skip to content

Code coverage for the Rust code #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 3 commits into from
Jun 30, 2023
Merged

Code coverage for the Rust code #642

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
111f799
CI: upgrade to Coveralls GitHub actions v2
imobachgs Jun 30, 2023
197cfec
CI: enable code coverage reporting for Rust
imobachgs Jun 30, 2023
9336b1a
CI: disable debugging for Coveralls actions
imobachgs Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,9 @@ jobs:
run: npm test -- --coverage

- name: Coveralls GitHub Action
uses: coverallsapp/github-action@v1
uses: coverallsapp/github-action@v2
with:
base-path: ./web
path-to-lcov: ./web/coverage/lcov.info
flag-name: frontend
parallel: true

Expand Down Expand Up @@ -93,12 +92,12 @@ jobs:
run: bundle exec rspec

- name: Coveralls GitHub Action
uses: coverallsapp/github-action@v1
uses: coverallsapp/github-action@v2
with:
base-path: ./service
path-to-lcov: ./service/coverage/lcov.info
flag-name: backend
parallel: true
debug: true
Comment thread
imobachgs marked this conversation as resolved.
Outdated

ruby_linter:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -172,9 +171,12 @@ jobs:

strategy:
fail-fast: false
matrix:
distro: [ "tumbleweed" ]

container:
image: registry.opensuse.org/opensuse/tumbleweed:latest
image: registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
options: --security-opt seccomp=unconfined

steps:

Expand All @@ -189,17 +191,34 @@ jobs:
run: zypper --non-interactive install rustup

- name: Install required packages
run: zypper --non-interactive install python-langtable-data openssl-3 libopenssl-3-devel
run: zypper --non-interactive install python-langtable-data openssl-3 libopenssl-3-devel jq

- name: Install Rust toolchains
run: rustup toolchain install stable

- name: Install cargo-binstall
uses: taiki-e/install-action@v2
with:
tool: cargo-binstall

- name: Install Tarpaulin (for code coverage)
run: cargo-binstall --no-confirm cargo-tarpaulin

@jreidinger jreidinger Jun 30, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we have third way to install rust stuff? rustup component, cargo install and now cargo-binstall? It start to be quite messy

@imobachgs imobachgs Jun 30, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify: rustup is for managing the rust toolchain. cargo install is for binary crates (building for sources) and cargo-binstall to avoid building for sources.


- name: Run the tests
run: cargo test --verbose
run: cargo tarpaulin --out xml

- name: Lint formatting
run: cargo fmt --all -- --check

- name: Coveralls GitHub Action
uses: coverallsapp/github-action@v2
with:
base-path: ./rust
format: cobertura
flag-name: rust-backend
parallel: true
debug: true

integration-tests:
timeout-minutes: 60
runs-on: ubuntu-latest
Expand Down Expand Up @@ -286,7 +305,7 @@ jobs:
finish:
runs-on: ubuntu-latest

needs: [frontend_build, ruby_tests]
needs: [frontend_build, ruby_tests, rust_ci]

steps:

Expand Down