Conversation
jreidinger
reviewed
Jun 30, 2023
jreidinger
reviewed
Jun 30, 2023
| tool: cargo-binstall | ||
|
|
||
| - name: Install Tarpaulin (for code coverage) | ||
| run: cargo-binstall --no-confirm cargo-tarpaulin |
Contributor
There was a problem hiding this comment.
so we have third way to install rust stuff? rustup component, cargo install and now cargo-binstall? It start to be quite messy
Contributor
Author
There was a problem hiding this comment.
Just to clarify: rustup is for managing the rust toolchain. cargo install is for binary crates (building for sources) and cargo-binstall to avoid building for sources.
jreidinger
approved these changes
Jun 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We do not have any report about the test coverage for the Rust code.
Solution
This PR enables code coverage reporting for the Rust code using Tarpaulin.
coverallsapp/github-action@v2now.rust_ciuses the yast-ruby container because the Coveralls GitHub Action was not working with the Tumbleweed image (IDK the reason).rust_ciuses the cobertura format instead of lcov because the file names in the latter are absolute (which looks wrong). See the list of supported formats if you are interested.Screenshots