Skip to content

[web] Add missing favicon #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgdavid merged 5 commits into from
Jan 3, 2023
Merged

[web] Add missing favicon #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bfba60
[web] Add favicon.svg
dgdavid Jan 2, 2023
247718d
[web] Update webpack config for copying the favicon to dist
dgdavid Jan 2, 2023
16a9b43
[web] Fix route to favicon.svg
dgdavid Jan 2, 2023
caf1f12
[web] Update changes file
dgdavid Jan 2, 2023
3cfbcec
Merge branch 'master' into fix-favicon
mvidner Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions web/package/cockpit-d-installer.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Mon Jan 2 12:53:50 UTC 2023 - David Diaz <dgonzalez@suse.com>

- Add missing favicon (gh#yast/d-installer#387).

-------------------------------------------------------------------
Mon Jan 2 11:46:37 UTC 2023 - Knut Anderssen <kanderssen@suse.com>

Expand Down
1 change: 1 addition & 0 deletions web/src/assets/favicon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion web/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" type="image/svg+xml" href="favicon.svg" />
<link rel="stylesheet" href="index.css">
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>D-Installer</title>
Expand Down
2 changes: 2 additions & 0 deletions web/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const packageJson = JSON.parse(fs.readFileSync('package.json'));
const copy_files = [
"./src/index.html",
"./src/manifest.json",
// TODO: consider using something more complete like https://github.com/jantimon/favicons-webpack-plugin
"./src/assets/favicon.svg",
];

const plugins = [
Expand Down