Merged
Conversation
Using the chamaleon-only version of SUSE logo.
mvidner
approved these changes
Jan 3, 2023
Contributor
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
Looks good to me, a web amateur
(I've used the web interface to resolve the merge conflict)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The browser is complaining about missing favicon. And it's true.
Solution
To use the shorter SUSE's logo version by now (i.e., the chameleon 🦎)
Testing
Tested manually
Screenshots
Notes
Apart from the final favicon that D-Installer will use, we also need to consider how to generate it for all kinds of devices. A good candidate could be https://github.com/jantimon/favicons-webpack-plugin, but let's do it in the future once the 404 has been fixed.