Skip to content

Improve ConnectionsDataList test #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 1 commit into from
Nov 17, 2022
Merged

Improve ConnectionsDataList test #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions web/src/ConnectionsDataList.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
*/

import React from "react";
import { screen, waitFor } from "@testing-library/react";
import { installerRender } from "./test-utils";
import { screen } from "@testing-library/react";
import { plainRender } from "./test-utils";
import ConnectionsDataList from "./ConnectionsDataList";
import { ConnectionTypes } from "./client/network";

Expand All @@ -40,28 +40,34 @@ const wiFiConnection = {
addresses: [{ address: "192.168.69.200", prefix: 24 }]
};

let conns = [];
const conns = [wiredConnection, wiFiConnection];

describe("ConnectionsDataList", () => {
describe("when no connections are given", () => {
it("renders nothing", async () => {
const { container } = installerRender(<ConnectionsDataList conns={conns} />, { usingLayout: false });
await waitFor(() => expect(container).toBeEmptyDOMElement());
it("renders nothing", () => {
const { container } = plainRender(<ConnectionsDataList conns={[]} />, { usingLayout: false });
expect(container).toBeEmptyDOMElement();
});
});

describe("when a list of connections are given", () => {
beforeEach(() => {
conns = [wiredConnection, wiFiConnection];
});
it("renders a list with the name and the IPv4 addresses of each connection", () => {
plainRender(<ConnectionsDataList conns={conns} />, { usingLayout: false });

it("renders a list with the name and the IPv4 addresses of each connection", async () => {
installerRender(<ConnectionsDataList conns={conns} />, { usingLayout: false });
screen.getByText("Wired 1");
screen.getByText("WiFi 1");
screen.getByText("192.168.122.20/24");
screen.getByText("192.168.69.200/24");
});
});

await screen.findByText("Wired 1");
await screen.findByText("WiFi 1");
await screen.findByText("192.168.122.20/24");
await screen.findByText("192.168.69.200/24");
describe("when the user clicks on a connection", () => {
it("calls the onSelect function", async () => {
const onSelect = jest.fn();
const { user } = plainRender(<ConnectionsDataList conns={conns} onSelect={onSelect} />, { usingLayout: false });
const connection = screen.getByRole("button", { name: "WiFi 1" });
await user.click(connection);
expect(onSelect).toHaveBeenCalledWith(expect.objectContaining({ id: "wifi-1" }));
});
});
});