Skip to content

Improve ConnectionsDataList test#313

Merged
imobachgs merged 1 commit intofeature/wireless-supportfrom
improve-test
Nov 17, 2022
Merged

Improve ConnectionsDataList test#313
imobachgs merged 1 commit intofeature/wireless-supportfrom
improve-test

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Nov 17, 2022 •
edited
Loading

  • Do not rely on async unless it is strictly needed.
  • Test that the onSelect callback is called.
  • Do not use a beforeEach function.

@coveralls
Copy link

coveralls commented Nov 17, 2022

Coverage Status

Coverage increased (+0.07%) to 73.689% when pulling 65d5b6e on improve-test into 4491ee2 on feature/wireless-support.

@imobachgs imobachgs mentioned this pull request Nov 17, 2022
Merged
teclator
teclator approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit fbd1ec4 into feature/wireless-support Nov 17, 2022
@imobachgs imobachgs deleted the improve-test branch November 17, 2022 08:32
@imobachgs imobachgs restored the improve-test branch November 23, 2022 09:04
@imobachgs imobachgs deleted the improve-test branch November 23, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teclator teclator teclator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imobachgs @coveralls @teclator