fix(storage): generate expected JSON when using current size#2737
Merged
joseivanlopez merged 2 commits intoagama-project:SLE-16from Sep 16, 2025
Merged
fix(storage): generate expected JSON when using current size#2737joseivanlopez merged 2 commits intoagama-project:SLE-16from
joseivanlopez merged 2 commits intoagama-project:SLE-16from
Conversation
joseivanlopez
force-pushed
the
bsc1249591
branch
from
97a5ea4 to
d58b024
Compare
joseivanlopez
changed the title
ancorgs
reviewed
Sep 15, 2025
ancorgs
reviewed
Sep 15, 2025
ancorgs
approved these changes
Sep 15, 2025
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
If this was tested manually, then LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The storage config is not properly exported to JSON when the size is configured to use the current size of the device, see https://github.com/agama-project/agama/blob/master/doc/storage_proposal_from_profile.md#using-current.
As side effect, devices marked to be shrunk in the UI were actually configured to shrink and grow at the same time. The proposal currently fails with such a config.
The problem only affects to the proposal calculated using the UI and it started to fail since this PR #2622. Although the real source of the problem (wrong exported JSON) has been always there.
Solution
Generate the correct JSON when using the current size of a device.
Testing