fix(ui): detect out of sync storage#2622
Merged
joseivanlopez merged 19 commits intoagama-project:ui-syncfrom Aug 6, 2025
Merged
fix(ui): detect out of sync storage#2622joseivanlopez merged 19 commits intoagama-project:ui-syncfrom
joseivanlopez merged 19 commits intoagama-project:ui-syncfrom
Conversation
joseivanlopez
changed the title
joseivanlopez
force-pushed
the
storage-reload
branch
6 times, most recently
from
2c30afe to
debe2cf
Compare
- For example, when there are several attempts to calculate a valid proposal.
joseivanlopez
force-pushed
the
storage-reload
branch
3 times, most recently
from
7e168cf to
8bb009d
Compare
- Includes the client_id as part of the event.
joseivanlopez
force-pushed
the
storage-reload
branch
from
8bb009d to
f362fb5
Compare
joseivanlopez
changed the title
dgdavid
reviewed
Aug 3, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Prevent errors when a device no longer exists, whether due to a mistyped URL or changes in the underlying system. It does so by introducing a new core component as a first step toward unifying how Agama handles forms and pages that rely on URL parameters. While this is an initial implementation, further refinement will be needed as adoption grows and ergonomic improvements are identified to make it fully adaptable and developer-friendly.
To show the out-of-sync alert when proceed.
This reverts commit 2bbc686.
I.e., only if changes in storage were originated by an action of the same client. It also drops some dead code and an unwanted hasResult condition.
Using the StorageChanged signal and the clientId prop to determine if the lasd changes are valid or not.
But still needing test since it is not fully working as expected.
joseivanlopez
force-pushed
the
storage-reload
branch
from
ff6ddc4 to
cb0f760
Compare
joseivanlopez
force-pushed
the
storage-reload
branch
from
d1b8e22 to
3360b88
Compare
- The out-of-sync alert is shown in all pages.
joseivanlopez
force-pushed
the
storage-reload
branch
from
3360b88 to
b5f77f6
Compare
dgdavid
reviewed
Aug 5, 2025
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Thanks @joseivanlopez
Web part LGTM despite the few minor comments I've left.
ancorgs
approved these changes
Aug 6, 2025
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
I see there is room to improve the behavior when you are at a form that stops making sense (eg. editing a partition that is not longer there in the new config).
But the current status is already much better than what we had before. So LGTM.
joseivanlopez
added a commit
that referenced
this pull request
Aug 7, 2025
joseivanlopez
added a commit
that referenced
this pull request
Sep 16, 2025
## Problem The storage config is not properly exported to JSON when the size is configured to use the current size of the device, see https://github.com/agama-project/agama/blob/master/doc/storage_proposal_from_profile.md#using-current. As side effect, devices marked to be shrunk in the UI were actually configured to shrink and grow at the same time. The proposal currently fails with such a config. The problem only affects to the proposal calculated using the UI and it started to fail since this PR #2622. Although the real source of the problem (wrong exported JSON) has been always there. ## Solution Generate the correct JSON when using the current size of a device. ## Testing * Unit tests adapted * Tested manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The storage UI does not automatically refresh when other clients perform changes (e.g., after loadig a config using the CLI). This happens to both the storage page and the storage section in the overview page.
Solution
Shows a blocking popup when there are storage changes performed by other clients. The user must click on reload in order to continue.