feat(web): add support for sorting devices in DeviceSelectorModal#2672
feat(web): add support for sorting devices in DeviceSelectorModal#2672
Conversation
dgdavid
changed the title
dgdavid
force-pushed
the
device-selector-sorting
branch
from
386d466 to
3cd8b9d
Compare
dgdavid
changed the title
Replaces repeated use of fast-sort's method chaining syntax with a wrapper that accepts the sort direction as a direct argument. This should improve readability and make it easier to build sorting logic dynamically, as done in components like DeviceSelectorModal and DASDTable.
dgdavid
force-pushed
the
device-selector-sorting
branch
from
ce5112d to
6c1e966
Compare
And add testing for sorting feature.
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
It generally looks good. Just a comment about inline documentation.
| @@ -1,7 +1,13 @@ | |||
| ------------------------------------------------------------------- | |||
| Tue Sep 2 08:24:38 UTC 2025 - David Diaz <dgonzalez@suse.com> | |||
There was a problem hiding this comment.
I see you were cleaning surplus spaces. Great!
But I was actually expecting two spaces between "Sep" and "2" (I think that's the default in this format for days with just one digit). But I don't think that really matters.
There was a problem hiding this comment.
But I was actually expecting two spaces between "Sep" and "2"
Me too.
Originally I "kept" it. In fact, I added it because I solved the conflict manually using the Github web interface... but CI complained about wrong date and the only thing I found the extra space. I can add it back, though.
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
Still LGTM after the latest merge. Hurry up and merge before another changelog conflict kicks in. :-)
3 participants
During the work to improve the DASD page, the core component used to build rich tables was extended to support user-driven sorting.
This makes it possible to add a small enhancement to the device selector dialog on the storage page, allowing users to sort the available devices by either name or size, useful when setting up the installation in a system with an noticeable amount of disks.