Conversation
* Package, PackageProposal and SpaceCalculation
imobachgs
force-pushed
the
software-proposal
branch
from
11c01a1 to
ee12d97
Compare
imobachgs
force-pushed
the
software-proposal
branch
from
643ee84 to
9978963
Compare
Pull Request Test Coverage Report for Build 2516233281
💛 - Coveralls |
joseivanlopez
left a comment
joseivanlopez
left a comment
There was a problem hiding this comment.
I see we still have a DBus::Clients::DInstaller providing #provision_selected? and #provision_selected? methods. I think we can drop that service.
| module Software | ||
| # D-Bus object to manage software installation | ||
| class Manager < ::DBus::Object | ||
| PATH = "/org/opensuse/DInstaller/Software1" |
There was a problem hiding this comment.
Shouldn't this be /org/opensuse/DInstaller/Software/Manager1? Similar to we did with storage.
There was a problem hiding this comment.
I do not see the need to have a manager path at all. For instance, we have /org/opensuse/DInstaller/Language1. I am not against it, though, but we should define what we prefer.
There was a problem hiding this comment.
Originally, the name of this file was main.rb. Would it be any better?
There was a problem hiding this comment.
I got confused, we don't have /org/opensuse/DInstaller/Storage/Manager1. For the future storage service, I would expect something like:
/org/opensuse/DInstaller/Storage1/org/opensuse/DInstaller/Storage/Proposal1/org/opensuse/DInstaller/Storage/Actions1
There was a problem hiding this comment.
You are right. I will get rid of that client.
* This reverts commit 08a05ff. * When Available is called, the software repositories has not been read yet.
| dbus_interface SOFTWARE_INTERFACE do | ||
| dbus_reader :available_base_products, "a(ssa{sv})" | ||
|
|
||
| dbus_watcher :available_base_products |
There was a problem hiding this comment.
I would say the watcher is not needed.
4 participants
Follow-up of #201 (see #168 for the original issue).
/org/opensuse/DInstaller/Software/Proposal1).Package,PackageProposalandSpaceCalculation.Open questions
Package#AvailableandPackage#Installedto D-Bus. Where? Should we merge all the calls in a single D-Bus object? Or should we add another one in addition to theProposal1object?Screenshots
As the web UI needs to be adapted, what about a
dinstallerctlscreenshot? 😅Tasks
Implement a Package#Available D-Bus method.