Move the software API to a separate service org.opensuse.DInstaller.Software#201
Merged
imobachgs merged 27 commits intomulti-processfrom Jun 17, 2022
Merged
Move the software API to a separate service org.opensuse.DInstaller.Software#201imobachgs merged 27 commits intomulti-processfrom
org.opensuse.DInstaller.Software#201imobachgs merged 27 commits intomulti-processfrom
Conversation
4bdc39f to
528c991
Compare
org.opensuse.DInstaller.Service
Pull Request Test Coverage Report for Build 2514470738
💛 - Coveralls |
org.opensuse.DInstaller.Serviceorg.opensuse.DInstaller.Service
org.opensuse.DInstaller.Serviceorg.opensuse.DInstaller.Service
dgdavid
approved these changes
Jun 17, 2022
|
|
||
| ORDERED_SERVICES = [:software, :users, :manager].freeze | ||
|
|
||
| # Start all the services |
| # | ||
| # @param done [Proc] Block to execute once the probing is done | ||
| def probe(&done) | ||
| return dbus_object.Probe unless block_given? |
Contributor
There was a problem hiding this comment.
This line is not needed. You can simply use dbus_object.Probe(&block), which will perform the D-Bus call without passing any block if the block was not given.
| end | ||
|
|
||
| # Exports the software object through the D-Bus service | ||
| def export |
Contributor
There was a problem hiding this comment.
At some point we will need a DBus::Base class.
org.opensuse.DInstaller.Serviceorg.opensuse.DInstaller.Software
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PRs moves the software management logic to a separate service,
org.opensuse.DInstaller.Software. See #168 for further information.Solution
This is the first PR to move the software API to a separate
org.opensuse.DInstaller.Software. It sets the basic infrastructure:SoftwareService.bin/d-installerto run all services at once or just one of them. More work is expected to improve this executable soon.Y2DIRper service.Testing
Tasks (other PRs)