Skip to content

Clarify inst.finish=stop #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvidner merged 2 commits into from
Feb 25, 2025
Merged

Clarify inst.finish=stop #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a55d389
Clarify inst.finish=stop
mvidner Feb 24, 2025
2bc9de2
factual fix of the clarification
mvidner Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/user/boot_options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,11 @@ first one can be removed anytime.
- `inst.finish`
During an unattended installation, if the installation is completed successfully then the
installer will reboot into the target system by default (`reboot`). This behavior can be modified
allowing to `stop`, `halt` or `poweroff` the machine at the end of the installation. An
interactive installation is not affected by this parameter.
allowing to `halt` or `poweroff` the machine at the end of the installation.
In addition to the three values corresponding to systemd commands, the value `stop` will
pause at the final "Congratulations! [Reboot]" screen, allowing you to
extract logs.
An interactive installation is not affected by this parameter.

```text
inst.finish=poweroff
Expand Down
5 changes: 3 additions & 2 deletions docs/user/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,9 @@ Finish the installation rebooting the system by default
Possible values:

- `stop`:
Stop at the end of the installation
- `reboot`:
Stop the installation at its end, at the "Congratulations! [Reboot]" screen,
leaving the backend running
Copy link
Copy Markdown
Contributor Author

@mvidner mvidner Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now I am wondering... agama finish stop seems to be a no-op then? What am I missing?

Copy link
Copy Markdown
Contributor

@teclator teclator Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly the case, what about renaming it to agama.finish=no, probably someone would expect then also the agama.finish=yes but by default reboot will be applied in case not a valid option an called from unattended installation, in the CLI it will report an error

Copy link
Copy Markdown
Contributor

@teclator teclator Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we sould mention the UI at all, I mean what is shown in the UI is because the installer is in the installed phase but maybe @imobachgs or @dgdavid have an stronger opinion

- `reboot` (default):
Reboot into the installed system
- `halt`:
Halt the installed machine
Expand Down