Skip to content

Clarify inst.finish=stop#50

Merged
mvidner merged 2 commits intomainfrom
clarify-inst-finish-stop
Feb 25, 2025
Merged

Clarify inst.finish=stop#50
mvidner merged 2 commits intomainfrom
clarify-inst-finish-stop

Conversation

@mvidner
Copy link
Contributor

@mvidner mvidner commented Feb 24, 2025

mention that the others correspond to systemd commands

(here my initial misconceptions and questions about `stop`) TODO: as a user I would like to know some more info about `stop`. Presumably this is a debugging option when I am doing a test and want to inspect the system. I assume that the web service will stop and the web UI will no longer work? Agama CLI will not work? So I should log in at the console, that's my only option? To continue, I should tell systemd to `reboot`, `poweroff` or `halt`?

We may also say that stop is an intermediate state that we don't want to overspecify.

mention that the others correspond to systemd commmands
@mvidner mvidner force-pushed the clarify-inst-finish-stop branch from 18f4f44 to a55d389 Compare February 24, 2025 09:47
@mvidner
Copy link
Contributor Author

mvidner commented Feb 24, 2025

This is a follow-up for #47

@teclator
Copy link
Contributor

teclator commented Feb 24, 2025

mention that the others correspond to systemd commmands

TODO: as a user I would like to know some more info about stop. Presumably this is a debugging option when I am doing a test and want to inspect the system. I assume that the web service will stop and the web UI will no longer work?

It will stop at the congratulation screen as it currently does allowing to reboot manually through the UI or the CLI

Screenshot From 2025-02-24 09-51-59

Agama CLI will not work? So I should log in at the console, that's my only option? To continue, I should tell systemd to reboot, poweroff or halt?

It will be available as well as the UI. Currently the only task is running is to save logs.

We may also say that stop is an intermediate state that we don't want to overspecify.

Stop at the end of the installation
- `reboot`:
Stop the installation at its end, at the "Congratulations! [Reboot]" screen,
leaving the backend running
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now I am wondering... agama finish stop seems to be a no-op then? What am I missing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly the case, what about renaming it to agama.finish=no, probably someone would expect then also the agama.finish=yes but by default reboot will be applied in case not a valid option an called from unattended installation, in the CLI it will report an error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we sould mention the UI at all, I mean what is shown in the UI is because the installer is in the installed phase but maybe @imobachgs or @dgdavid have an stronger opinion

@mvidner mvidner merged commit 27437d0 into main Feb 25, 2025
4 checks passed
@mvidner mvidner deleted the clarify-inst-finish-stop branch February 25, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants