Make call to extractAll() function behave as call to extract() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to the `extractAll` function seems to make a semantically incorrect usage of `args.srcFiles[0]`. The `extract` function uses `arg.folder` as an output specifier, and `args.srcFiles` as an input specifier. `extractAll` should drop input parameters. This patch modifies the `extractAll` call to use `args.folder` to specify output. However, this may cause backwards-incompatible changes with any scripts that use `--extract-all`, so this should wait for the next major version (keeping with SemVer called for in Issue 8). aff4#8 This patch is independent of Pull Request 14. aff4#14 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to the
extractAllfunction seems to make a semanticallyincorrect usage of
args.srcFiles[0]. Theextractfunction usesarg.folderas an output specifier, andargs.srcFilesas an inputspecifier.
extractAllshould drop input parameters.This patch modifies the
extractAllcall to useargs.foldertospecify output. However, this may cause backwards-incompatible changes
with any scripts that use
--extract-all, so this should wait for thenext major version (keeping with SemVer called for in Issue 8).
#8
This patch is independent of Pull Request 14.
#14
Signed-off-by: Alex Nelson [email protected]