Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should start to use semantic versioning. #8

Open
scudette opened this issue Apr 23, 2019 · 0 comments
Open

Should start to use semantic versioning. #8

scudette opened this issue Apr 23, 2019 · 0 comments

Comments

@scudette
Copy link
Member

The latest pypi push broke all dependent projects because the api has changed. Pyaff4 should start to use semantic versioning from now on to ensure people can rely on it being stable moving forward.

https://github.com/google/rekall/issues/493
@ajnelson-nist ajnelson-nist mentioned this issue Sep 23, 2019
Merged
blschatz pushed a commit that referenced this issue Oct 21, 2019
@ajnelson-nist @blschatz
Make call to extractAll() function behave as call to extract() (#16)
20f2c51 
The call to the `extractAll` function seems to make a semantically
incorrect usage of `args.srcFiles[0]`.  The `extract` function uses
`arg.folder` as an output specifier, and `args.srcFiles` as an input
specifier.  `extractAll` should drop input parameters.

This patch modifies the `extractAll` call to use `args.folder` to
specify output.  However, this may cause backwards-incompatible changes
with any scripts that use `--extract-all`, so this should wait for the
next major version (keeping with SemVer called for in Issue 8).
#8

This patch is independent of Pull Request 14.
#14

Signed-off-by: Alex Nelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scudette