Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH/DOC] Unsupervised and semi-supervised usage of PyODAdapter #1932

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

SebastianSchmidl
Copy link
Member

Reference Issues/PRs

Fixes #1837

What does this implement/fix? Explain your changes.

  • Code cleanup in KMeansAD
  • Document different detector categories in docs
  • Enhance PyODAdapter to support both fit_predict and fit-and-predict usage

Does your contribution introduce a new dependency? If yes, which one?

no

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.

@SebastianSchmidl SebastianSchmidl added documentation Improvements or additions to documentation enhancement New feature, improvement request or other non-bug code enhancement anomaly detection Anomaly detection package labels Aug 8, 2024
@SebastianSchmidl SebastianSchmidl self-assigned this Aug 8, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$, $\color{#0B1D38}{\textsf{datasets}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the API doc page for now, but eventually would want a link to a notebook which contains this info though.

@SebastianSchmidl
Copy link
Member Author

Fine with the API doc page for now, but eventually would want a link to a notebook which contains this info though.

Created an issue for that: #1960

@SebastianSchmidl SebastianSchmidl merged commit c4f39b3 into main Aug 13, 2024
15 checks passed
@SebastianSchmidl SebastianSchmidl deleted the feat/pyod-adapter branch August 13, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly detection Anomaly detection package documentation Improvements or additions to documentation enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PyODAdapter only returns decision_scores_ of train-set
2 participants