Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix 2 typos in distances notebook #1873

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Datadote
Copy link
Contributor

What does this implement/fix? Explain your changes.

  1. Sum of squares equation is missing square -> added ^2
  2. Sentence grammar error, missing "as" ->added "as"

Does your contribution introduce a new dependency? If yes, which one?

  • No
For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added documentation Improvements or additions to documentation examples Example notebook related labels Jul 31, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#F3B9F8}{\textsf{documentation}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst added the distances Distances package label Jul 31, 2024
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great spot, thanks

@TonyBagnall
Copy link
Contributor

@all-contributors add @Datadote for docs

Copy link
Contributor

@TonyBagnall

I've put up a pull request to add @Datadote! 🎉

@TonyBagnall TonyBagnall merged commit e5dd34f into aeon-toolkit:main Aug 1, 2024
4 checks passed
SebastianSchmidl pushed a commit that referenced this pull request Aug 13, 2024
* feat: support unsupervised and semi-supervised usage of PyODAdapter and fix #1873

* refactor: avoid code duplication in kmeans

* feat: improve documentation of anomaly detection module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distances Distances package documentation Improvements or additions to documentation examples Example notebook related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants