Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hilt version to 2.46.1 #162

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

aftabahmadTW
Copy link
Contributor

@aftabahmadTW aftabahmadTW commented Jun 14, 2023

There is currently a bug where the library is incompatible with the latest releases of hilt and causes a crash. This is due to the HiltViewModelFactory constructor which has changed:

public HiltViewModelFactory(
      @NonNull Set<String> hiltViewModelKeys,
      @NonNull ViewModelProvider.Factory delegateFactory,
      @NonNull ViewModelComponentBuilder viewModelComponentBuilder) {

I've updated the library and tested with the HiltListViewModel to verify it works properly.

@adrielcafe
Copy link
Owner

@aftabahmadTW thanks for your contribution!

@adrielcafe adrielcafe merged commit 6d2daec into adrielcafe:main Aug 28, 2023
JeppeLeth added a commit to matadorapp/voyager that referenced this pull request Sep 13, 2023
…ted dependencies

* Add compose multiplatform support to voyager-koin (adrielcafe#159)

* Update hilt version to 2.46.1 (adrielcafe#162)

Co-authored-by: Adriel Café <[email protected]>

* Update to Compose 1.5 (adrielcafe#195)

* Update to Compose 1.5

* Fix sample

* Fix bottom sheet navigator

* Remove test function

* Fix RxJava multiplatform

* Runtime saveable is now added by default

* Remove accidental change

* Update other dependencies

* Fix runtimeSaveable

* chore: bump dependencies

* feat: add sheetGesturesEnabled param

* chore: fix lint

* chore: update to java 17 on release workflow

* fix AndroidScreenLifecycleOwner.kt merge

* sheet hidden fix

* return true

* update kotlin and compose versions to latest

---------

Co-authored-by: florian schoeberl <[email protected]>
Co-authored-by: Aftab Ahmad <[email protected]>
Co-authored-by: Adriel Café <[email protected]>
Co-authored-by: Mitchell Syer <[email protected]>
programadorthi pushed a commit to programadorthi/voyager that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants