Add compose multiplatform support to voyager-koin (Closes #158) #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
geworfener
commented
Jun 13, 2023
geworfener
commented
- Add new koin-compose dependency
- Setup Module for Compose Multiplatform
- Tested on Android, iOS, Desktop JVM, Web JS
geworfener
changed the title
|
Koin supports Compose Multiplatform -> InsertKoinIO/koin#1208 (comment) |
|
Looking to use this |
|
The same! This would be very useful! @adrielcafe 🙏 |
|
@geworfener thanks for your contribution! |
|
plz update the doc for that |
1 similar comment
|
plz update the doc for that |
JeppeLeth
added a commit
to matadorapp/voyager
that referenced
this pull request
Sep 13, 2023
…ted dependencies * Add compose multiplatform support to voyager-koin (adrielcafe#159) * Update hilt version to 2.46.1 (adrielcafe#162) Co-authored-by: Adriel Café <[email protected]> * Update to Compose 1.5 (adrielcafe#195) * Update to Compose 1.5 * Fix sample * Fix bottom sheet navigator * Remove test function * Fix RxJava multiplatform * Runtime saveable is now added by default * Remove accidental change * Update other dependencies * Fix runtimeSaveable * chore: bump dependencies * feat: add sheetGesturesEnabled param * chore: fix lint * chore: update to java 17 on release workflow * fix AndroidScreenLifecycleOwner.kt merge * sheet hidden fix * return true * update kotlin and compose versions to latest --------- Co-authored-by: florian schoeberl <[email protected]> Co-authored-by: Aftab Ahmad <[email protected]> Co-authored-by: Adriel Café <[email protected]> Co-authored-by: Mitchell Syer <[email protected]>
programadorthi
pushed a commit
to programadorthi/voyager
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.