Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compose multiplatform support to voyager-koin (Closes #158) #159

Merged

Conversation

geworfener
Copy link
Contributor

  • Add new koin-compose dependency
  • Setup Module for Compose Multiplatform
  • Tested on Android, iOS, Desktop JVM, Web JS

@geworfener geworfener changed the title Add compose multiplatform support to voyager-koin Add compose multiplatform support to voyager-koin (Closes #158) Jun 13, 2023
@mslalith
Copy link

mslalith commented Jul 1, 2023

Koin supports Compose Multiplatform -> InsertKoinIO/koin#1208 (comment)
@Syer10 Looks like this can be merged now

@alfietapping
Copy link

Looking to use this

@ferranpons
Copy link

The same! This would be very useful! @adrielcafe 🙏

@adrielcafe
Copy link
Owner

@geworfener thanks for your contribution!

@adrielcafe adrielcafe merged commit d10e918 into adrielcafe:main Aug 28, 2023
@aplha98
Copy link

aplha98 commented Sep 7, 2023

plz update the doc for that

1 similar comment
@aplha98
Copy link

aplha98 commented Sep 7, 2023

plz update the doc for that

JeppeLeth added a commit to matadorapp/voyager that referenced this pull request Sep 13, 2023
…ted dependencies

* Add compose multiplatform support to voyager-koin (adrielcafe#159)

* Update hilt version to 2.46.1 (adrielcafe#162)

Co-authored-by: Adriel Café <[email protected]>

* Update to Compose 1.5 (adrielcafe#195)

* Update to Compose 1.5

* Fix sample

* Fix bottom sheet navigator

* Remove test function

* Fix RxJava multiplatform

* Runtime saveable is now added by default

* Remove accidental change

* Update other dependencies

* Fix runtimeSaveable

* chore: bump dependencies

* feat: add sheetGesturesEnabled param

* chore: fix lint

* chore: update to java 17 on release workflow

* fix AndroidScreenLifecycleOwner.kt merge

* sheet hidden fix

* return true

* update kotlin and compose versions to latest

---------

Co-authored-by: florian schoeberl <[email protected]>
Co-authored-by: Aftab Ahmad <[email protected]>
Co-authored-by: Adriel Café <[email protected]>
Co-authored-by: Mitchell Syer <[email protected]>
programadorthi pushed a commit to programadorthi/voyager that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants