Update internally used node to 18.x #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
approved these changes
Jun 25, 2024
|
Up next: adding @ember/string to the test app |
NullVoxPopuli
merged commit 9c6fc8d
into
adopted-ember-addons:master
5 of 9 checks passed
Merged
NullVoxPopuli
changed the title
|
With the merge of #411, we longer have an engines field, so there should not be any dependence on any node version anywore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of some PR, to get CI green & bring the addon to addon v2 blueprint.
We start to drop node < 18, this should already bring a green CI for our tests ember < 3.28. The other do still fail, because we need more changes
Next steps are described here #378 (comment)