Skip to content

Commit

Permalink
Merge pull request #402 from mkszepp/drop-node
Browse files Browse the repository at this point in the history
Drop support for node < 18
  • Loading branch information
NullVoxPopuli committed Jun 25, 2024
2 parents b3ad8be + 8942dd4 commit 9c6fc8d
Show file tree
Hide file tree
Showing 4 changed files with 12,048 additions and 13 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- uses: actions/checkout@v1
- uses: volta-cli/action@v1
- uses: actions/checkout@v4
- uses: volta-cli/action@v4
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v2
- uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
Expand All @@ -43,12 +43,12 @@ jobs:
fail-fast: false
matrix: ${{fromJson(needs.test.outputs.matrix)}}
steps:
- uses: actions/checkout@v1
- uses: volta-cli/action@v1
- uses: actions/checkout@v4
- uses: volta-cli/action@v4
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v2
- uses: actions/cache@v4
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
Expand Down
9 changes: 5 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
}
},
"engines": {
"node": ">= 12"
"node": ">= 18"
},
"ember-addon": {
"version": 2,
Expand Down Expand Up @@ -148,7 +148,8 @@
}
},
"volta": {
"node": "14.17.5",
"yarn": "1.22.11"
}
"node": "18.20.3",
"yarn": "1.22.22"
},
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
}
6 changes: 3 additions & 3 deletions test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@
"webpack": "^5.65.0"
},
"engines": {
"node": "12.* || 14.* || >= 16"
"node": ">= 18"
},
"ember": {
"edition": "octane"
},
"volta": {
"node": "14.17.5",
"yarn": "1.22.11"
"node": "18.20.3",
"yarn": "1.22.22"
}
}
Loading

0 comments on commit 9c6fc8d

Please sign in to comment.