Adding locale and moment computeds #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
force-pushed
the
locale-support
branch
9 times, most recently
from
477a00d
to
cd01cea
Compare
|
@stefanpenner need a review when you can. I'm holding off on merging this one until you do since I want to get it right. |
jasonmit
force-pushed
the
locale-support
branch
from
cd01cea
to
beb148b
Compare
|
Paging Mr. @stefanpenner |
This was referenced Jan 19, 2016
Mr @stefanpenner!! |
|
LVGTM 👍 |
jasonmit
force-pushed
the
locale-support
branch
from
be87a04
to
c84d846
Compare
jasonmit
force-pushed
the
locale-support
branch
from
126e945
to
4712418
Compare
jasonmit
added a commit
that referenced
this pull request
Jan 23, 2016
Adding locale and moment computeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
This is API breaking due to the duration computed having to be split out into duration + humanize in order to have the ability to localize duration before humanizing through composition.