Computeds do not respect service locale

[jasonmit]

Computed macros do not respect the service's locale, but that's probably not something we can easily solve unless we decide to inject moment into all common factory types.

What we can do, and probably should do, is support some way of specifying a locale. Below are two proposals.

format('createdOn', 'MM/DD/YYYY', {
  locale: 'moment.locale'
})

Or support computed composition

locale(moment('createdOn'), 'moment.locale')

[jasonmit]

@stefanpenner I'm leaning towards the composition approach since it's more flexible and condusive to supporting the entire moment API:

//examples of composition

locale(moment('createdOn'), 'moment.locale')

calendar(moment('createdOn'), null, {
  sameDay: '[Today]',
  nextDay: '[Tomorrow]',
  nextWeek: 'dddd',
  lastDay: '[Yesterday]',
  lastWeek: '[Last] dddd',
  sameElse: 'DD/MM/YYYY'
})

diff(moment('createdOn'), new Date())

fromNow(moment('createdOn'))

toNow(moment('createdOn'))

duration(10, 'hours')

[stefanpenner]

locale(format(moment('createdOn'), 'MM/DD/YYYY'), 'moment.locale')

isn't the format also locale specific?

[stefanpenner]

diff(moment('createdOn'), new Date())

fromNow(moment('createdOn'))

toNow(moment('createdOn'))

duration(10, 'hours')

this looks good, but seems orthogonal to the locale issue right?

[stefanpenner]

Computed macros do not respect the service's locale, but that's probably not something we can easily solve unless we decide to inject moment into all common factory types.

I'm kinda fine with that, but likely only if the thing injected is unlikely to collide with peoples existing properties.

[jasonmit]

Yes, bad example. You would not use format with locale.

[jasonmit]

this looks good, but seems orthogonal to the locale issue right?

Not really. Since we would be adding locale support to all those computeds by fixing this issue, this means adding a tail argument or supporting an options hash. And the more I thought about it, the more it makes sense to just mimic the chaining behavior of moment API with our computeds.

locale(fromNow(moment('createdOn')), 'moment.locale')
locale(toNow(moment('createdOn')), 'moment.locale')
locale(duration(10, 'hours'), 'moment.locale')

or

format('createdOn', 'moment.locale')
fromNow('createdOn', 'moment.locale')
toNow('createdOn', 'moment.locale')
duration(10, 'hours', 'moment.locale')

The above approach is more or less what we have today, minus the tail argument for locale. It's problematic though since there are arguments in between moment and the locale that would need to be explicitly passed. So the above would really look like:

format('createdOn', 'MM/DD/YYYY', 'LLLL', 'moment.locale')
fromNow('createdOn', false, 'moment.locale')
toNow('createdOn', false, 'moment.locale')
duration(10, 'hours', 'moment.locale')

The advantages:

• Familiar chaining behavior of moment
• The computed callbacks implementation would result in something like moment[fn](...unwrappedArguments); reducing the complexity of the addon
• Not having to implement locale support in each of the computeds explicitly
• Not having to inject the moment service into every popular type factory avoiding your concern of prop key collision

The disadadvantages:

• API breaking