forked from anomalyco/opencode
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(app): show error toast on OAuth callback failure #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5a67253
fix: unblock prompts, gateway, and keybinds
adolago 3ad47e3
fix: don't try to open command palette if a dialog is already open (#…
BlankParticle a4814ba
fix(tui): correct theme count tip
adolago 02b4517
fix(task): propagate agent options through prompt
adolago da68d27
fix(mcp): honor per-server request timeouts
adolago c6b7376
fix(grep): handle ripgrep exit code 2
adolago 7922673
fix(tui): use v2 auth.set params
adolago 620815e
test: avoid global provider mock
adolago 6e327e9
docs: add testing guide
adolago 39010bf
fix(clipboard): auto-compress large images before API submission
adolago 14c39e5
fix(app): show error toast on OAuth callback failure
adolago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Testing | ||
|
|
||
| ## Automated (Non-UI) | ||
|
|
||
| Run from repo root: | ||
|
|
||
| ```bash | ||
| cd packages/agent-core | ||
| bun test | ||
| bun run typecheck | ||
| ``` | ||
|
|
||
| ## Manual (TUI / UI) | ||
|
|
||
| Run from repo root: | ||
|
|
||
| ```bash | ||
| cd packages/agent-core | ||
| bun dev | ||
| ``` | ||
|
|
||
| Smoke checklist: | ||
|
|
||
| - TUI launches and renders without crashing. | ||
| - `Ctrl+X H` toggles `HOLD`/`RELEASE` mode. | ||
| - `Ctrl+T` cycles model variants (for models that define variants). | ||
| - Provider dialog accepts an API key and shows success toast. | ||
|
|
||
| ## Latest Run (2026-01-17) | ||
|
|
||
| - `cd packages/agent-core && bun test` (pass) | ||
| - `cd packages/agent-core && bun run typecheck` (pass) | ||
| - `cd packages/agent-core && bun dev` (launched TUI) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines now advertise Telegram
toas “Chat ID (numeric) or @username”, but the execution path still doesparseInt(to, 10)and treats non‑numeric IDs as invalid. When a user follows this new guidance and supplies an@username, the tool returns “Invalid Telegram chat ID” and never calls/gateway/telegram/send. Either keep the description numeric‑only or accept string usernames and forward them to the gateway.Useful? React with 👍 / 👎.