fix(app): show error toast on OAuth callback failure #4
Conversation
- Add image compression when clipboard images exceed 4MB (API limit is 5MB) - Use ImageMagick for progressive compression (quality 85→30, resize 100%→25%) - Convert oversized PNGs to optimized JPEGs - Graceful fallback if ImageMagick unavailable fix(provider): allow instructions param for Codex API - Add "instructions" to OpenAI supported params whitelist - Fixes "Instructions are required" error with gpt-5.2-codex Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously when the OAuth callback failed, the dialog would close silently without informing the user of the error. Now shows an error toast with a helpful message. Resolves TODO comment in the code.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14c39e5ff4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Telegram: | ||
| - \`to\`: Numeric chat ID (from incoming message context) | ||
| - \`persona\`: Which bot to use - "stanley" (default) or "johny" | ||
| - to: Chat ID (numeric) or @username |
There was a problem hiding this comment.
These lines now advertise Telegram to as “Chat ID (numeric) or @username”, but the execution path still does parseInt(to, 10) and treats non‑numeric IDs as invalid. When a user follows this new guidance and supplies an @username, the tool returns “Invalid Telegram chat ID” and never calls /gateway/telegram/send. Either keep the description numeric‑only or accept string usernames and forward them to the gateway.
Useful? React with 👍 / 👎.
| Telegram: | ||
| - \`to\`: Numeric chat ID (from incoming message context) | ||
| - \`persona\`: Which bot to use - "stanley" (default) or "johny" | ||
| - \`to\`: Chat ID (numeric) or @username |
There was a problem hiding this comment.
This description now claims Telegram to can be a numeric ID or @username, but the implementation below still parses to with parseInt and rejects non‑numeric values. Users following the new guidance will hit the “Invalid Telegram chat ID” path and the message won’t be sent. Either update the docs back to numeric‑only or accept string usernames and pass them through to the gateway.
Useful? React with 👍 / 👎.
Summary
Previously when the OAuth callback failed, the dialog would close silently without informing the user of the error. Now shows an error toast with a helpful message.
Changes
Testing