-
Notifications
You must be signed in to change notification settings - Fork 236
docs(opacity-checkerboard): enhance README with detailed usage #5751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
tools/opacity-checkerboard/README.md
Outdated
| <div | ||
| class="opacity-checkerboard" | ||
| style="inline-size: 100px; block-size: 100px;" | ||
| aria-label="Checkerboard pattern indicating transparent areas" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are trying to surface up semantic meaning to the users but you shouldn't label the checkerboard itself. You can expose that information via a text node or a live region that updates as opacity changes.
<div
class="opacity-checkerboard"
style="inline-size: 100px; block-size: 100px;"
aria-hidden="true"
></div>
<span class="visually-hidden">Checkerboard pattern indicating transparent areas</span>There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opacity Checkerboard is just a visual indicator it should remain hidden from screen readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opacity checkerboard is indeed just a visual pattern and shouldn't be announced to screen readers. I agree that the semantic meaning should come from the context where it's used, not the checkerboard itself. I have added aria-hidden:true in the documentation.
Self Review - Documentation ChangesStructure Reorganization
Key ImprovementsEnhanced Content
Accessibility Implementation
Code Quality
Standards Compliance
|
nikkimk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this one!
docs(opacity-checkerboard): enhance README with detailed sections
Overview
This PR reorganizes the opacity-checkerboard README.md to follow the established documentation standards structure, improving accessibility and consistency with other components.
Changes Made
Structure Reorganization
bash,javascript)Code Quality Improvements
Accessibility Enhancements
role="img"for visual indicatorsaria-labelattributes for contextvisually-hiddenclassTesting
html-livesyntaxRelated Documentation
This PR follows the documentation standards outlined in:
Screenshots
N/A - Documentation only changes
Before/After Structure Comparison
Before:
After:
Checklist
html-liveexamples render correctly in documentation environmentThis reorganization makes the opacity-checkerboard documentation more accessible, easier to navigate, and consistent with the established documentation standards across the Spectrum Web Components library, following the same structure and approach used in PR #5728.