Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): remove @adobe/spectrum-token dep from storybook #3528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Jan 29, 2025

Description

Update storybook to use the @spectrum-css/tokens tokens.json data instead of pulling in a duplicate source from @adobe/spectrum-tokens.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Expect to see color palette styles with no regressions

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Jan 29, 2025
@castastrophe castastrophe self-assigned this Jan 29, 2025
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 870c84f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 29, 2025

🚀 Deployed on https://pr-3528--spectrum-css.netlify.app

Copy link
Contributor

github-actions bot commented Jan 29, 2025

File metrics

Summary

Total size: 3.25 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe changed the title feat(storybook,tokens): remove @adobe/spectrum-token dep, export json feat(storybook): remove @adobe/spectrum-token dep from storybook Jan 29, 2025
@castastrophe castastrophe force-pushed the feat-storybook-remove-token-dep branch 3 times, most recently from 8e18368 to 4c57af5 Compare January 30, 2025 21:49
@castastrophe castastrophe marked this pull request as ready for review January 30, 2025 21:49
@castastrophe castastrophe added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. storybook ready-for-review labels Jan 30, 2025
@castastrophe castastrophe force-pushed the feat-storybook-remove-token-dep branch 2 times, most recently from e7d8b82 to 3cf3477 Compare January 31, 2025 19:01
@castastrophe castastrophe force-pushed the feat-storybook-remove-token-dep branch from 3cf3477 to 870c84f Compare February 1, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. skip_vrt Add to a PR to skip running VRT (but still pass the action) storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant