Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade stylelint use and plugins to support v16 #2780

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented May 22, 2024

Description

Stylelint v16 has been released and includes ESM support. This PR upgrades our stylelint to use the latest version as well as our internal plugins to support the v16 release.

This also adds a Plugins test to our development workflow so that we can verify breaks or regressions by surfacing the results of the existing plugins test suite to the GitHub results but only when something in the plugins directory is updated.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

  • Expect the Plugins test GitHub Action to run for this PR and pass
  • yarn linter actionbutton: Expect no deprecation warnings
  • yarn formatter actionbutton: Expect no deprecation warning

To-do list

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: 8a871f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@spectrum-tools/stylelint-no-unknown-custom-properties Major
@spectrum-tools/stylelint-no-unused-custom-properties Major
@spectrum-tools/stylelint-no-missing-var Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from 4e36de3 to 3ee3236 Compare May 22, 2024 20:01
Copy link
Contributor

github-actions bot commented May 22, 2024

🚀 Deployed on https://pr-2780--spectrum-css.netlify.app

@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from 3ee3236 to 907ce18 Compare May 22, 2024 20:03
Copy link
Contributor

github-actions bot commented May 22, 2024

File metrics

Summary

Total size: 4.63 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe self-assigned this May 22, 2024
@castastrophe castastrophe added skip_vrt Add to a PR to skip running VRT (but still pass the action) ready-for-review labels May 22, 2024
@castastrophe castastrophe requested a review from pfulton May 22, 2024 20:12
@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from 907ce18 to 47c80f2 Compare May 22, 2024 20:16
Copy link
Collaborator

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 I pulled this down locally and am getting unknown custom property errors:
image

This warning message came before it but that may be expected:
image

Is there a step I missed or is this expected behavior?

@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from 47c80f2 to c749c2d Compare May 28, 2024 13:34
@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from c749c2d to cbfa253 Compare June 6, 2024 18:49
@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from cbfa253 to a172942 Compare June 27, 2024 15:13
@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch 2 times, most recently from 5b062c3 to 0467b92 Compare July 25, 2024 16:51
@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from 0467b92 to 2f4fb6b Compare July 25, 2024 16:56
Copy link
Collaborator

@rise-erpelding rise-erpelding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great now!

image image

@castastrophe castastrophe force-pushed the feat-upgrade-stylelint-v16-support branch from 2f4fb6b to 8a871f5 Compare July 25, 2024 17:24
@castastrophe castastrophe enabled auto-merge (squash) July 25, 2024 17:29
@castastrophe castastrophe merged commit 7fea737 into main Jul 25, 2024
23 of 24 checks passed
@castastrophe castastrophe deleted the feat-upgrade-stylelint-v16-support branch July 25, 2024 17:34
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants