This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Remove unnecessary project tree refresh after save as #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… incorrectly sets the current working set document as the tree selection
ghost
assigned 
| @@ -1210,8 +1210,6 @@ define(function (require, exports, module) { | |||
|
|
|||
| if (_lastSelected) { | |||
| selectedEntry = _lastSelected.data("entry"); | |||
| } else { | |||
There was a problem hiding this comment.
This is code that has erroneously ben added by #6382?
I have validated that the file selection in various configurations works as expected when refreshing the file tree, i.e. with or with out selection in Working set or project tree. No bugs found.
|
Since the code is just removing the call to refreshFileTree and placing the contents of the done handler of the removed call to be handled synchronously and immediately it all makes sense to me. No objections. Unit + Integration tests are passing. merging. |
couzteau
added a commit
that referenced
this pull request
Jan 14, 2014
Remove unnecessary project tree refresh after save as
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6499.
Also back out some code from #6382 where we incorrectly try to restore the tree selection using the working set selection (current document) instead of the file tree. This fix alone would also fix the bug, but now that we have file watchers, the call to
ProjectManager.refreshFileTreebecomes obsolete.