Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Remove unnecessary project tree refresh after save as #5914

Open
core-ai-bot opened this issue Aug 30, 2021 · 1 comment
Open

[CLOSED] Remove unnecessary project tree refresh after save as #5914

core-ai-bot opened this issue Aug 30, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by jasonsanjose
Monday Jan 13, 2014 at 22:14 GMT
Originally opened as adobe/brackets#6507

Fixes #6499.

Also back out some code from #6382 where we incorrectly try to restore the tree selection using the working set selection (current document) instead of the file tree. This fix alone would also fix the bug, but now that we have file watchers, the call to ProjectManager.refreshFileTree becomes obsolete.

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/6507/commits
@core-ai-bot
Copy link
Member Author

Comment by couzteau
Tuesday Jan 14, 2014 at 23:58 GMT

Since the code is just removing the call to refreshFileTree and placing the contents of the done handler of the removed call to be handled synchronously and immediately it all makes sense to me. No objections.

Unit + Integration tests are passing. merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot