Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Monkeypatch: in CodeMirror, revert less.js to a working version #6058

Merged
merged 1 commit into from
Nov 20, 2013

Conversation

njx
Copy link

@njx njx commented Nov 20, 2013

For #6057, this hotfixes the CodeMirror submodule to point to a temporary branch (also named post-sprint-34-hotfix) that reverts the LESS mode to codemirror/codemirror5@390a47e. A bug was introduced in codemirror/codemirror5@6fd2965 that was later fixed (after our most recent upstream merge). Rather than try to take the latest upstream or monkeypatch in the bugfixes, we thought it would be safer to just revert codemirror/codemirror5@6fd2965 since it was a rather large change to the LESS mode and we probably don't need the fixes in that commit right now.

@RaymondLim
Copy link
Contributor

I reviewed the changes and just found that less.js is the only file reverted to the version in sprint 33. I also tested with different less files and didn't see any issues. I will let @bchintx to decide what to do with this pull request since he has to make the corresponding change in EC.

@ghost ghost assigned bchintx Nov 20, 2013
@bchintx
Copy link
Contributor

bchintx commented Nov 20, 2013

Whoops. Just saw @RaymondLim 's comment, but not until after I did the same. :-)

Verified that the updated SHA only changes the one less file, and then confirmed that issue #6057 is fixed with this change.

Merging this pull request, and then creating a new one to echo this change in Edge Code.

bchintx added a commit that referenced this pull request Nov 20, 2013
Monkeypatch: in CodeMirror, revert less.js to a working version
@bchintx bchintx merged commit 36c32fa into master Nov 20, 2013
@bchintx bchintx deleted the post-sprint-34-hotfix branch November 20, 2013 04:56
@pthiess
Copy link
Contributor

pthiess commented Nov 20, 2013

@njx @RaymondLim @bchintx - Cool! Thanks a ton -:)

@FezVrasta
Copy link
Contributor

There is a way to replace the bugged less.js in the Sprint 34 without compile it or use the git version? Thanks.

@njx
Copy link
Author

njx commented Nov 26, 2013

Yes, as a workaround, you could manually copy that file over from our adobe/CodeMirror2 fork into the appropriate place in your local Brackets install (under src/thirdparty/CodeMirror2).

@FezVrasta
Copy link
Contributor

Thank you very much. It worked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants