Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Sprint 34 Hotfix #5630

Open
core-ai-bot opened this issue Aug 30, 2021 · 3 comments
Open

[CLOSED] Sprint 34 Hotfix #5630

core-ai-bot opened this issue Aug 30, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by jasonsanjose
Tuesday Dec 03, 2013 at 19:13 GMT
Originally opened as adobe/brackets#6168


Contains fixes from:

Also, update version strings to 0.34.1.

Please note that this pull request is merging to a new sprint-34-hotfix branch and not master.


jasonsanjose included the following code: https://github.com/adobe/brackets/pull/6168/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Dec 03, 2013 at 19:14 GMT


I have a vague recollection that there was also a tern/acorn update -@dangoor, is that right?

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday Dec 03, 2013 at 19:28 GMT


@njx There was #6064 but afaik that's not necessary to fix the regression. The Acorn bug itself has existed for several sprints, and it only manifested in weird edge cases like #5847. The nasty regression was purely due to the ScoepManager visit code changing, and that part is 100% fixed by Kevin's #6068. (I think EC is in that same boat: it has #6068 but not #6064).

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Tuesday Dec 03, 2013 at 19:49 GMT


Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant