Makeotf fixes #458
Merged
Makeotf fixes #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsousa
force-pushed
the
makeotf-fixes
branch
from
56744df
to
134a994
Compare
cjchapman
suggested changes
Jul 9, 2018
.travis.yml
Outdated
| @@ -3,7 +3,7 @@ matrix: | |||
| include: | |||
| - os: linux | |||
| env: NAME=Linux | |||
| if: type = pull_request | |||
| if: NOT branch =~ /^\d+\.\d+\.\d+.*$/ | |||
There was a problem hiding this comment.
Please add detailed comments here and for each of the changes below so that future generations may learn more quickly than we did how and why to do this kind of thing.
There was a problem hiding this comment.
(Also, there are lots of minor issues that I'd like for us to clean up in MakeOTF.py, but nothing specific to the changes.)
because it leads to a UnicodeDecodeError later on. Bug introduced in 35783e4#diff-12c55c7004f8c76ee2b1741243a67cda Using decode here brings back issue #222 (UnicodeDecodeError: 'ascii' codec can't decode byte). Cosimo's patch (#222 (comment)) was included in f1c4511#diff-8c875fc8969988dc6583127ac4fb12f7
Completes the fix of #264
The files were sourced from https://github.com/adobe-type-tools/cmap-resources https://github.com/adobe-type-tools/Adobe-Japan1 https://github.com/adobe-type-tools/Adobe-GB1 https://github.com/adobe-type-tools/Adobe-CNS1
… of its format Historically, when the input font is CID the output OTF is written to the current directory, whereas in other input formats it's written to the same directory as the input font. This difference is odd, onerous and prone to error. This change makes the output OTF be written to the same directory as the input font regardless of its format. To make the output OTF be written to the current directory use option '-o .'
Makes it easier to do minor updates and makes the updates more transparent (since they'll be diff-able)
…rderAndAliasDB There's really no reason for treating UFO and Type 1 inputs differently in this regard
They were matching commented out FEA code, and compiling them outside of the method makes it more efficient (especially since the method is recursive) Fixes #148
This allows us to test the CI of a branch without having to start a PR
miguelsousa
force-pushed
the
makeotf-fixes
branch
from
134a994
to
5e3f43a
Compare
cjchapman
approved these changes
Jul 9, 2018
This was referenced Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148, #222, #264, #457 and #459