Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeotf option description is not accurate (-cs / -cl) #459

Closed
LIXiangChen opened this issue Jul 4, 2018 · 2 comments
Closed

makeotf option description is not accurate (-cs / -cl) #459

LIXiangChen opened this issue Jul 4, 2018 · 2 comments
Assignees

Comments

@LIXiangChen
Copy link

LIXiangChen commented Jul 4, 2018

option -cs / -cl described as follows:

Override the heuristics, and specify the ScriptID / LanguageID for the Macintosh 'cmap' subtable; CID-keyed fonts only.

By my test, the option is not only available for CID-keyed fonts, also works for name-keyed fonts.

@LIXiangChen LIXiangChen changed the title makeotf option description is not accurate (-cs / -cl) makeotf option description is not accurate (-cs / -cl) Jul 4, 2018
@miguelsousa
Copy link
Member

@LIXiangChen thanks for the report, I get the same results.

@readroberts what should be done here? 1. Change the documentation, or 2. change the implementation? I favor 1, because I don't see a reason for limiting those options to CID fonts.

@miguelsousa miguelsousa self-assigned this Jul 5, 2018
@readroberts
Copy link
Contributor

@msousa In the short term, I would change the documentation. I would, however, prefer to change makeotf to not make Mac cmap tables, which I believe have not been needed for some years, and suppress the related options. However, this will require some time for testing and research to see if it is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants