Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeotf] PSNameNotSpecified.otf #282

Closed
frankrolf opened this issue Mar 12, 2018 · 2 comments
Closed

[makeotf] PSNameNotSpecified.otf #282

frankrolf opened this issue Mar 12, 2018 · 2 comments
Assignees
Labels

Comments

@frankrolf
Copy link
Member

When building an OTF from a UFO without PS name, a zero-kB file named PSNameNotSpecified.otf is created. This is unnecessary.
In addition to that, I think makeotf could try and create the PS name automatically (from UFO Family/Style Name) if it doesn’t exist.

@frankrolf frankrolf added the bug label Mar 12, 2018
@miguelsousa miguelsousa mentioned this issue Mar 12, 2018
5 tasks
@frankrolf
Copy link
Member Author

I think the deeper problem here is that makeotf requires the postscriptFontName in a UFO be set. makeInstancesUFO no longer requires the ps font name (as per this commit), so perhaps it would be a good idea to remove that requirement from makeotf altogether.

@miguelsousa miguelsousa self-assigned this Jun 28, 2018
miguelsousa added a commit that referenced this issue Jun 29, 2018
Makes it behave the same as when a Type 1 font with no '/FontName' is used as input

Fixes #282
@miguelsousa
Copy link
Member

makeotf.py is too messy to try to squeeze in a fallback solution for when postscriptFontName is missing in a UFO. So in #451 I simply made makeotf behave the same way as when a Type 1 font without /FontName is used as input, which is it fails.

I'll definitely try to implement a fallback solution for the rewrite version.

miguelsousa added a commit that referenced this issue Jun 29, 2018
Makes it behave the same as when a Type 1 font with no '/FontName' is used as input

Fixes #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants