Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite MakeOTF.py #249

Closed
5 tasks
miguelsousa opened this issue Jan 29, 2018 · 6 comments
Closed
5 tasks

Rewrite MakeOTF.py #249

miguelsousa opened this issue Jan 29, 2018 · 6 comments

Comments

@miguelsousa
Copy link
Member

miguelsousa commented Jan 29, 2018

After going thru the process of doing some light cleanup to MakeOTF.py it became very clear to me that this script is in dire need of a rewrite. The main goals of this rewrite are:

  • Streamline the script to 50% LOC or less
  • Support Python 3.x (in addition to 2.7)
  • Implement tests
  • Use argparse
  • Use logging (instead of print)

The way I'd like to go about it is to start from scratch a script named makeotf_new.py and build it gradually. Once this script has feature-parity with MakeOTF.py it will be renamed and replace the old one. I will define the first milestone for us to work on.

@miguelsousa miguelsousa added this to the New `makeotf_new.py` with minimal functionality milestone Jan 29, 2018
@kenlunde
Copy link

Another goal of this rewrite should be to integrate the latest-and-greatest subroutinizer in tx that takes seconds or minutes to subroutinize large CJK fonts, instead of the current hours or days.

@miguelsousa
Copy link
Member Author

@kenlunde that sounds like a different goal. MakeOTF.py is just a wrapper for makeotfexe. I think that you should open a separate issue to get that enhancement into makeotfexe.

@cjchapman
Copy link
Contributor

cjchapman commented Jan 29, 2018

I suggest:

  • replace uses of eval() with cleaner/clearer alternatives
  • replace uses of exec() with cleaner/clearer alternatives
  • specify expected exception types (i.e. no bare except statements)

@miguelsousa
Copy link
Member Author

@cjchapman I agree with those. My expectation is that by rewriting it from scratch we'll use cleaner/clearer alternatives from the start.

@miguelsousa
Copy link
Member Author

Address #280 #281 #282

@miguelsousa miguelsousa removed this from the New `makeotf2.py` with minimal functionality milestone Aug 14, 2019
@miguelsousa
Copy link
Member Author

Enough has happened to makeotf.py since that it makes more sense to keep improving it.
Two of the original goals (Py3 and tests) have been addressed, and there's #861 to track the shifting to argparse and logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants