Move to Eslint for linting #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Apr 23, 2019
vrunoa
pushed a commit
to vrunoa/wd
that referenced
this pull request
Jan 6, 2020
* Remove jshint * Add eslint machinery * Fix linting * Lint in Travis
vrunoa
pushed a commit
to vrunoa/wd
that referenced
this pull request
Jan 6, 2020
Giving bromann some love. waitFor considers errors whose message includes "timeout" retriable. At a high level, this seems reasonable, assuming that a timeout error might be caused by the fact that the condition we're checking for has not been met yet. Since we're willing to wait for the condition to become true, we should be willing to retry when a timeout happens. Concretely, this patch is motivated by the need to stabilize a flaky test in our suite that fails due to a tough bug in ChromeDriver [1, 2, 3]. The failure mode is transient, so retrying fixes the flakiness. [1] https://bugs.chromium.org/p/chromedriver/issues/detail?id=402 [2] https://bugs.chromium.org/p/chromedriver/issues/detail?id=817 [3] http://stackoverflow.com/questions/34926866/selenium-chromedriver-timed-out-receiving-message-from-renderer-exception Add new android emulators commands (admc#488) * add new android emulators commands * add emulator methods * update release notes * bump version Prompt user more info to debug when error comes from init() (admc#489) * Prompt user more info to debug when error comes from init() * Try to pass travis Add sample for Kobiton cloud service add ios class chain locator strategy 1.5.0 Remove need for install script links pointing to api docs on code.google.com are broken Add rejectUnauthorized to http config opts update package lock 1.6.0 fix: check if jsonData exists on error creation for request admc#520 1.6.1 upgrade request module (fix admc#523) 1.6.2 add driver.get(set)Clipboard isKeyboardShown method 1.7.0 Fix linter errors Fix HTTP tests broken by admc#521 Add a note about chromedriver The latest releases of Chrome will not work with the outdated chromedriver version installed by sv-selenium. Add a note. Upgrade archiver to 2.1.1 Upgrade lodash to 4.17.10 Add basic support for new W3C protocol 1.8.0 fix situation where jsonwireres is itself not defined 1.8.1 longPressKeyCode, getSupportedPerformanceDataTypes & getPerformanceData methods 1.9.0 Fixed wrong description for "/session/:sessionId/log" add elementByImage command 1.10.0 Add getter for TouchAction on ImageElement object 1.10.1 Remove underscore.string mixin make finding by image first class methods because it's now supported on the server fix hidden use of underscore.string in tests (cc @imurchie) 1.10.2 might as well have plural of element(s)ByImageFile 1.10.3 Add W3C Actions API Test hitting of /actions endpoint * Added test that mocks POST actions/ and checks that the client produces the correct result * Also changed ID of mouse to "default mouse" Add W3C release actions find element by ios predicate string Upgrading the Sauce Connect version Supplying lodash to the modules, to see if I can get a test pass Fixing more broken lodash depedencies More missing lodash Adding ANY to acceptable platforms for VISTA More lodash waitForVisible is dead, commenting the test, fixing what appears to be API issues with lodash by removing .value(), not sure why that was necessary but this passes the build and works properly Removing node 5 requirement, and temporarily disable ipad, iphone, android, bump node version to 10 First round of security audit package updates integrating new geckodriver support from PR admc#494 Revert "Remove need for install script" Integrating all changes from PR admc#530 Revert "Integrating all changes from PR admc#530" This reverts commit b0405da. add flags for press keycodes Try removing linux as platform constraint bump sauce connect, remove the linux build platform constraint Executing JS commands doesn't work with new firefox apparently Removing remaining _.value() calls that seem no longer important, fixing the make targets Revert "Removing remaining _.value() calls that seem no longer important, fixing the make targets" This reverts commit 9159ff7. Removing underscore value() just for the api mapping code Looks like map and filter both need _.value(), removing all others Most repos I see aren't pushing the package-lock.json add custom find strategy Revert "Most repos I see aren't pushing the package-lock.json" This reverts commit 3ad3668. 1.11.0 fix a typo on sessionID in webdriver [admc#555] Update request dependency * Fixed hinting issues [WIP] Chrome fixes upgrade the sauce-connect-launcher package to deal with security vulneratibilities in the depedencies Updating the mocha runner, also contains security vulns This bitdeli thing seems to no longer exist Upgrade lodash to pickup fix for prototype pollution vulnerability Vulnerability details: https://hackerone.com/reports/380873 Lodash changelog: https://github.com/lodash/lodash/wiki/Changelog#v41711 1.11.1 Update document options for flick endpoint Try upgrading gulp to 4.0 to unbreak CI Revert "Try upgrading gulp to 4.0 to unbreak CI" This reverts commit 6537ea8. trying to lock the gulp dev dependency to fix this failing CI Removing the secure fields from the travis yaml, trying to use travis environment variables that work for pull requests Provide W3C and MJSONWP caps Make W3C opt-in Fix capability handling Rename for fork Fix prefixing 1.11.2 Revert package changes Fix Fix Fix Fix feat: Android Espresso DataMatcher strategy Remove additional space Fixed 'npm run test' unit tests for Windows platform Fix hardcoded saucelabs domain 1.11.2 Work on Travis build Update deps and work on tests (admc#591) Move to Eslint for linting (admc#592) * Remove jshint * Add eslint machinery * Fix linting * Lint in Travis Move to gulp@4 (admc#593) 1.11.3 Include "gulp-mocha" and "fancy-log" as dev dependencies Bump lodash from 4.17.11 to 4.17.13 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.13) Signed-off-by: dependabot[bot] <[email protected]> fix: naming of tasks in gulp tasks 1.11.4 support W3C get active element command /element/active requires POST method in JWP but W3C WebDriver spec requires GET method. https://www.w3.org/TR/webdriver/#get-active-element This patch checks remote WebDriver server speaks JWP or W3C on creating a session and remember it. Then switch method of /element/active looksing the flag. chore: Sauce Connect 4.5.4 add httpAgent as right now the connection is not kept alive change test script, wasnt working for me using test-unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from jshint, to eslint. I've opted to not lint for formatting, just for usage. More and more projects are turning to things like prettier to do formatting automatically, without the need for static analysis.