Removing remaining _.value() calls that seem no longer important, fix…

…ing the make targets
vrunoa · Sep 19, 2018 · 9159ff7 · 9159ff7
1 parent 391f48f
commit 9159ff7
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/doc/mapping-builder.js b/doc/mapping-builder.js
@@ -38,7 +38,7 @@ _(jsonWireFull).each(function (jw_v, jw_k) {
       }).size() > 0){
         var orderTag = _(wd_v.tags).filter(function (t) {
           return t.type === 'docOrder';
-        }).value();
+        });
         var order = 1000000;
         if (orderTag.length > 0){
          order =  parseInt(orderTag[0].string, 10);
@@ -47,7 +47,7 @@ _(jsonWireFull).each(function (jw_v, jw_k) {
           return l !== '';
         }).map(function (l) {
             return {line: l};
-        }).value();
+        });
         current.wd_doc.push({
           'desc': desc,
           'order': order
@@ -58,7 +58,7 @@ _(jsonWireFull).each(function (jw_v, jw_k) {
 
   current.wd_doc = _(current.wd_doc).sortBy(function (docItem) {
     return docItem.order;
-  }).value();
+  });
   current.wd_doc0 = current.wd_doc.length === 0;
   current.wd_doc1 = current.wd_doc.length === 1? current.wd_doc : null;
   current.wd_docN = current.wd_doc.length > 1? current.wd_doc: null;
@@ -87,7 +87,7 @@ _(jsonDocs).each(function (jsonDoc) {
         return  l !== '';
       }).map(function (l) {
         return {line: l};
-      }).value();
+      });
       current.wd_doc.push({ 'desc': desc });
       current.wd_doc1 = current.wd_doc;
 
@@ -113,7 +113,7 @@ _(jsonDocs).each(function (jsonDoc) {
         return  l !== '';
       }).map(function (l) {
         return {line: l};
-      }).value();
+      });
       current.wd_doc.push({ 'desc': desc });
       current.wd_doc1 = current.wd_doc;
 
@@ -139,7 +139,7 @@ _(jsonDocs).each(function (jsonDoc) {
         return  l !== '';
       }).map(function (l) {
         return {line: l};
-      }).value();
+      });
       current.wd_doc.push({ 'desc': desc });
       current.wd_doc1 = current.wd_doc;
 
@@ -168,7 +168,7 @@ _(jsonDocs).each(function (jsonDoc) {
           return  l !== '';
         }).map(function (l) {
           return {line: l};
-        }).value();
+        });
         current.wd_doc.push({desc: desc});
         current.wd_doc1 = current.wd_doc;
         resMapping.push(current);

diff --git a/lib/actions.js b/lib/actions.js
@@ -159,7 +159,7 @@ MultiAction.prototype.toJSON = function() {
   if(this.element) { output.elementId = this.element.value; }
   output.actions = _(this.actions).map(function(action) {
     return action.toJSON();
-  }).value();
+  });
   return output;
 };
 

diff --git a/lib/main.js b/lib/main.js
@@ -117,7 +117,7 @@ function remote() {
     'promise': PromiseWebdriver,
     'promiseChain': PromiseChainWebdriver
   };
-  var driverTypes = _(driverProtos).keys().value();
+  var driverTypes = _(driverProtos).keys();
   var driverType = driverTypes.indexOf(_(args).last())>0 ? args.pop() : 'async';
 
   var rwc = parseRemoteWdConfig(args);

diff --git a/test/midway/add-methods-async-specs.js b/test/midway/add-methods-async-specs.js
@@ -48,7 +48,7 @@ describe('add-methods - async' + env.ENV_DESC, function() {
   };
 
   var allExtraMethodNames = _.union(
-    _(extraAsyncMethods).keys().value()
+    _(extraAsyncMethods).keys()
   );
 
   var noExtraMethodCheck = function() {

diff --git a/test/midway/add-methods-pc-specs.js b/test/midway/add-methods-pc-specs.js
@@ -114,9 +114,9 @@ describe('add-methods - promise-chain' + env.ENV_DESC, function() {
   };
 
   var allExtraMethodNames = _.union(
-    _(extraAsyncMethods).keys().value(),
-    _(extraPromiseChainMethods).keys().value(),
-    _(extraPromiseNoChainMethods).keys().value()
+    _(extraAsyncMethods).keys(),
+    _(extraPromiseChainMethods).keys(),
+    _(extraPromiseNoChainMethods).keys()
   );
 
   var noExtraMethodCheck = function() {

diff --git a/test/midway/add-methods-pnc-specs.js b/test/midway/add-methods-pnc-specs.js
@@ -84,8 +84,8 @@ describe('add-methods - promise-no-chain' + env.ENV_DESC, function() {
   };
 
   var allExtraMethodNames = _.union(
-    _(extraAsyncMethods).keys().value(),
-    _(extraPromiseNoChainMethods).keys().value()
+    _(extraAsyncMethods).keys(),
+    _(extraPromiseNoChainMethods).keys()
   );
 
   var noExtraMethodCheck = function() {