-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "Off The Record" / Hidden post mode #712
base: master
Are you sure you want to change the base?
Conversation
Updated |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Update: the hidden posts are now properly excluded from the Sitemap |
Note: this branch is temporarily broken - Update: fixed |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The branch was rewritten to include the last changes published upstream |
I finally published a post about this feature integration in Papermod: https://roneo.org/en/hugo-hidden-posts/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoneoOrg The page is still listed in
- section pages
consider a page http://localhost:1313/blogg/markdown/
the page is successfully hidden from home but is listed at http://localhost:1313/blogg/ - tags and term pages
the tags are counted and listed at http://localhost:1313/tags/
also term pages are generated ex http://localhost:1313/tags/sometag
Hi and thanks for the review! The Quoting myself:
The only change I may contribute is to rename the feature from
Nice catch! I'm adding this issue to the list in the first post^^ |
In an ideal scenario, only single.html should generate the page and everywhere else it should be bypassed We won't merge it until it works everywhere. Because you don't use tags you'll not be fixing it 🤷♂️. We won't go ahead with this one then until someone else makes a PR who wishes to make it work everywhere. |
Sure! I'll ping the devs that showed interest in this feature |
That's a shame: I can't retrieve the usernames of the people who thumbed up this PR. |
Yes that's what I did, but Github autocompletion did not find any match, I guess these visible account names do not correspond to the usernames I could ping with |
Okay @RoneoOrg @yashasolutions, @philipgriffin, @Th3Shadowbroker, and @gtreshchev Please help us with this PR if anyone is available |
sorry didn't see the notification earlier, is there anything that need to be done? |
Hi there, here is a recap of the stuff to be done:
/cc @yashasolutions |
Kudos, SonarCloud Quality Gate passed! |
Now every external link is opened is a new tab with |
957e2c9
to
6f0c88d
Compare
Kudos, SonarCloud Quality Gate passed! |
Conflicts: layouts/_default/list.html
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Todo:
|
bcd75b6
to
55b2eb4
Compare
What does this PR change? What problem does it solve?
I sometime want to share a post with selected readers only, for review or private discussion.
This branch adds a Front Matter variable
offTheRecord
, which allows you to publish a post and share the URL while hiding this post from:The search engine indexation is also set to
noindex, nofollow
for these posts.What's left to do?
/tags/
pages (#wontfix: I do not use tags in OTR posts)This branch is published early, unpolished, for the interested. I will probably have no time to work on it in the near future, feel free to build upon / close this PR
Was the change discussed in an issue or in the Discussions before?
Not on this tracker, but this is an implementation of an idea by Zachary Wade Betz, reviewed and discussed on discourse.gohugo.io.
PR Checklist