-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hiddenPage
mode
#1162
Add hiddenPage
mode
#1162
Conversation
hugo docs mention that booleans shouldn't be quoted -> https://gohugo.io/functions/where/#use-where-with-booleans
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @icy-comet and thanks for tackling this issue, I've been working on it in this dedicated PR, that's fine you work on your side (and Anyway, here are my suggestions: |
Any update on this @icy-comet ? The main branch of Papermod is still getting updates, so the delta between Papermod and this branch is getting wider and wider, making harder and harder to maintain such a PR.. Note that you submitted a new PR heavily based on a PR I previously submitted (See ^), adding lots of noise over an already complicated piece of code. I kindly reviewed your proposal, added some notes, and politely waited, and now the burden is heavier. So.. do you want (and have the possibility to) to tackle this issue until it's merged? |
hi @RoneoOrg. It's not possible for me to work on this now. I think the PR was already complete though. Hope you see its merging through. |
What does this PR change? What problem does it solve?
Completes and closes #712.
Changes from previous PR:
rel
(s) on a hiddenPageDisallow
directive for every hiddenPage and its resourcesWas the change discussed in an issue or in the Discussions before?
#712
PR Checklist